Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amdvlk: 2020.Q4.1 -> 2020.Q4.2 #102073

Merged
merged 1 commit into from Nov 2, 2020
Merged

amdvlk: 2020.Q4.1 -> 2020.Q4.2 #102073

merged 1 commit into from Nov 2, 2020

Conversation

@Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 29, 2020

Motivation for this change

2020.Q4.2 was published: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q4.2

Things done
  • Tested vkcube and dota 2
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

Result of nixpkgs-review pr 102073 run on x86_64-linux 1

2 packages failed to build:
  • amdvlk
  • driversi686Linux.amdvlk
CMake Error at /nix/store/r9djcvv9hh6cma006jxlcz3xljz7zck0-cmake-3.18.2/share/cmake-3.18/Modules/CMakeTestCCompiler.cmake:66 (message):
  The C compiler

    "/nix/store/8madhhcxhxlf0rrc5hdsk65l206r3cc6-gcc-wrapper-9.3.0/bin/gcc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /build/amdvlk-src/build/CMakeFiles/CMakeTmp

    Run Build Command(s):/nix/store/ba77flp1iya22w2v7yih1vwz8z4zwdnb-ninja-1.10.1/bin/ninja cmTC_a68c3 && ninja: fatal: posix_spawn: No such file or directory





  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:130 (project)


-- Configuring incomplete, errors occurred!
See also "/build/amdvlk-src/build/CMakeFiles/CMakeOutput.log".
@Flakebi
Copy link
Member Author

@Flakebi Flakebi commented Oct 30, 2020

Result of nixpkgs-review pr 102073 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk

Works fine for me.
Does /nix/store/ba77flp1iya22w2v7yih1vwz8z4zwdnb-ninja-1.10.1/bin/ninja exist on your system? (It should be pulled in by the package definition)

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102073 run on x86_64-linux 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk
Copy link
Member

@danieldk danieldk left a comment

Thanks! LGTM

@danieldk danieldk merged commit f38d5cf into NixOS:master Nov 2, 2020
18 of 19 checks passed
18 of 19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@github-actions
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@ofborg
amdvlk, amdvlk.passthru.tests on aarch64-linux No attempt
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@ofborg
amdvlk, amdvlk.passthru.tests on x86_64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3b3fe07"; rev="3b3fe0744d705a75bf36474b50f2566ee1e2a78b"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3b3fe07"; rev="3b3fe0744d705a75bf36474b50f2566ee1e2a78b"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3b3fe07"; rev="3b3fe0744d705a75bf36474b50f2566ee1e2a78b"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3b3fe07"; rev="3b3fe0744d705a75bf36474b50f2566ee1e2a78b"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3b3fe07"; rev="3b3fe0744d705a75bf36474b50f2566ee1e2a78b"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3b3fe07"; rev="3b3fe0744d705a75bf36474b50f2566ee1e2a78b"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3b3fe07"; rev="3b3fe0744d705a75bf36474b50f2566ee1e2a78b"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Flakebi Flakebi deleted the Flakebi:amdvlk branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants