Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackbox-exporter: 0.17.0 -> 0.18.0 #102094

Merged
merged 1 commit into from Oct 30, 2020

Conversation

@Frostman
Copy link
Member

@Frostman Frostman commented Oct 29, 2020

Motivation for this change

https://github.com/prometheus/blackbox_exporter/releases/tag/v0.18.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 29, 2020

That won't work. You need to update the hash.

@Frostman Frostman force-pushed the Frostman:blackbox-exporter-0.18.0 branch from b6a99fe to 4e3da4a Oct 29, 2020
@Frostman
Copy link
Member Author

@Frostman Frostman commented Oct 29, 2020

@SuperSandro2000 thx, good catch, pushed the wrong rev

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102094 run on x86_64-linux 1

1 package built:
  • prometheus-blackbox-exporter
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102094 run on x86_64-darwin 1

1 package built:
  • prometheus-blackbox-exporter
@WilliButz
Copy link
Member

@WilliButz WilliButz commented Oct 30, 2020

@GrahamcOfBorg test prometheus-exporters.blackbox

@WilliButz WilliButz merged commit a3c16e9 into NixOS:master Oct 30, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4e3da4a"; rev="4e3da4adc82fec01e75fdbd0f9a94b547b7a5692"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4e3da4a"; rev="4e3da4adc82fec01e75fdbd0f9a94b547b7a5692"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4e3da4a"; rev="4e3da4adc82fec01e75fdbd0f9a94b547b7a5692"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4e3da4a"; rev="4e3da4adc82fec01e75fdbd0f9a94b547b7a5692"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4e3da4a"; rev="4e3da4adc82fec01e75fdbd0f9a94b547b7a5692"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4e3da4a"; rev="4e3da4adc82fec01e75fdbd0f9a94b547b7a5692"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4e3da4a"; rev="4e3da4adc82fec01e75fdbd0f9a94b547b7a5692"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
tests.prometheus-exporters.blackbox on aarch64-linux Success
Details
@ofborg
tests.prometheus-exporters.blackbox on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants