Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cshatag: init at 2019-12-03 #102102

Merged
merged 1 commit into from Nov 1, 2020
Merged

cshatag: init at 2019-12-03 #102102

merged 1 commit into from Nov 1, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 29, 2020

Motivation for this change

Silent data corruption paranoia

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102102 run on x86_64-linux 1

1 package marked as broken and skipped:
  • cshatag
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102102 run on x86_64-darwin 1

Edit: Why does ofborg think this builds something on darwin?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102102 run on x86_64-linux 1

1 package built:
  • cshatag
@rnhmjoj rnhmjoj force-pushed the rnhmjoj:cshatag branch from f03683f to 2aaf963 Oct 31, 2020
@rnhmjoj
Copy link
Contributor Author

@rnhmjoj rnhmjoj commented Oct 31, 2020

I removed attr from the builds inputs, which I forgot to do earlier. This is needed to run the test suite but it's not working: the tests need user extended attributes which are not availalble in the Nix build sandbox.

@rnhmjoj rnhmjoj merged commit 93e0a06 into NixOS:master Nov 1, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
cshatag, cshatag.passthru.tests on x86_64-darwin
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
cshatag, cshatag.passthru.tests on aarch64-linux Success
Details
@ofborg
cshatag, cshatag.passthru.tests on x86_64-linux Success
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2aaf963"; rev="2aaf9630191349b9d634323d9e4a46adf0609b9f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2aaf963"; rev="2aaf9630191349b9d634323d9e4a46adf0609b9f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2aaf963"; rev="2aaf9630191349b9d634323d9e4a46adf0609b9f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2aaf963"; rev="2aaf9630191349b9d634323d9e4a46adf0609b9f"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2aaf963"; rev="2aaf9630191349b9d634323d9e4a46adf0609b9f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2aaf963"; rev="2aaf9630191349b9d634323d9e4a46adf0609b9f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2aaf963"; rev="2aaf9630191349b9d634323d9e4a46adf0609b9f"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants