Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] p4: 2020.1.1991450 -> 2020.1.2007551 #102108

Merged
merged 1 commit into from Oct 29, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 29, 2020

Motivation for this change

closes #101955
backport #101470

The download URL hasn't changed, but the sha256 and user facing download
version has. See perforce downloads.

(cherry picked from commit b197c7f)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The download URL hasn't changed, but the sha256 and user facing download
version has. See [perforce downloads][p4-download].

[p4-download]: https://www.perforce.com/downloads/helix-command-line-client-p4

(cherry picked from commit b197c7f)
@jonringer jonringer merged commit c964865 into NixOS:release-20.09 Oct 29, 2020
1 of 3 checks passed
1 of 3 checks passed
@github-actions
action
Details
@github-actions
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@ofborg
grahamcofborg-eval Checking original out paths
Details
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 29, 2020

https://github.com/NixOS/nixpkgs/pull/102108
1 package built:
p4
@jonringer jonringer deleted the jonringer:backport-p4 branch Oct 29, 2020
@ofborg ofborg bot requested a review from corngood Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants