Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-review: build with python3 #102109

Merged
merged 1 commit into from Oct 29, 2020
Merged

git-review: build with python3 #102109

merged 1 commit into from Oct 29, 2020

Conversation

@kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Oct 29, 2020

Motivation for this change

#101964

Also updated source to the new repo and added myself as a maintainer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    Submitted a simple test code review with a single file added
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Also updated source to the new repo and added myself as a maintainer
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 102109 1

1 package built:
  • git-review

@jonringer jonringer merged commit ff4a1cf into NixOS:master Oct 29, 2020
13 of 16 checks passed
13 of 16 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@github-actions
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@ofborg
grahamcofborg-eval Calculating Changed Outputs
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="95c652d"; rev="95c652d895f71427d7e2275d89807e3d83adb863"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="95c652d"; rev="95c652d895f71427d7e2275d89807e3d83adb863"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="95c652d"; rev="95c652d895f71427d7e2275d89807e3d83adb863"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="95c652d"; rev="95c652d895f71427d7e2275d89807e3d83adb863"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="95c652d"; rev="95c652d895f71427d7e2275d89807e3d83adb863"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="95c652d"; rev="95c652d895f71427d7e2275d89807e3d83adb863"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="95c652d"; rev="95c652d895f71427d7e2275d89807e3d83adb863"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants