Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spago: 0.16.0 -> 0.17.0 #102117

Merged
merged 1 commit into from Oct 30, 2020
Merged

spago: 0.16.0 -> 0.17.0 #102117

merged 1 commit into from Oct 30, 2020

Conversation

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Oct 30, 2020

Motivation for this change

Spago released a new version: https://github.com/purescript/spago/releases/tag/0.17.0

I ran the following, and spago appears to compile and work:

$ ./pkgs/development/tools/purescript/spago/update.sh
$ sudo nix-build -A spago.passthru.tests --option sandbox relaxed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@braunse
Copy link
Contributor

@braunse braunse commented Oct 30, 2020

Result of nixpkgs-review pr 102117 1

2 packages built:
  • haskellPackages.spago
  • spago

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102117 run on x86_64-darwin 1

2 packages built:
  • haskellPackages.spago
  • spago

@cdepillabout
Copy link
Member Author

@cdepillabout cdepillabout commented Oct 30, 2020

Thanks for the review!

@cdepillabout cdepillabout merged commit add6a1e into NixOS:master Oct 30, 2020
19 of 20 checks passed
@cdepillabout cdepillabout deleted the spago-0.17 branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants