Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attica: drop #102120

Merged
merged 1 commit into from Oct 30, 2020
Merged

attica: drop #102120

merged 1 commit into from Oct 30, 2020

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 30, 2020

Motivation for this change

As far as I can tell, this file is completely unused.

Everything that uses attica uses it from pkgs/development/libraries/kde-frameworks/attica.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
as far as I can tell, this file is completely unused.

Everything that uses attica uses it from pkgs/development/libraries/kde-frameworks/attica.nix
@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 30, 2020

Always good to see someone picking up trash 👍

@bhipple
Copy link
Contributor

@bhipple bhipple commented Oct 30, 2020

Result of nixpkgs-review pr 102120 1

43 packages marked as broken and skipped:
- digitalbitbox
- glibcCross
- libsForQt5.khotkeys
- libsForQt5.mlt
- libsForQt512.khotkeys
- libsForQt512.kpmcore
- linuxPackages_4_4.evdi
- linuxPackages_5_8.exfat-nofuse
- linuxPackages_5_9.exfat-nofuse
- linuxPackages_hardkernel_4_14.bcc
- linuxPackages_hardkernel_4_14.bpftrace
- linuxPackages_hardkernel_4_14.can-isotp
- linuxPackages_hardkernel_4_14.chipsec
- linuxPackages_hardkernel_4_14.digimend
- linuxPackages_hardkernel_4_14.evdi
- linuxPackages_hardkernel_4_14.mba6x_bl
- linuxPackages_hardkernel_4_14.nvidia_x11_legacy390
- linuxPackages_hardkernel_4_14.nvidiabl
- linuxPackages_latest-libre.exfat-nofuse
- linuxPackages_latest_hardened.exfat-nofuse
- linuxPackages_latest_xen_dom0.exfat-nofuse
- linuxPackages_latest_xen_dom0_hardened.exfat-nofuse
- linuxPackages_testing_bcachefs.exfat-nofuse
- linuxPackages_zen.exfat-nofuse
- muslCross
- php73Extensions.pcs
- php73Packages.phpmd
- php74Extensions.pcs
- privateer
- pybitmessage
- python27Packages.caffe
- python27Packages.flitBuildHook
- python27Packages.libmodulemd
- python27Packages.pyqt5_with_qtwebkit
- python37Packages.nixpart
- python37Packages.notify
- python37Packages.pyblock
- python37Packages.pyqt5_with_qtwebkit
- python38Packages.libselinux
- python38Packages.nixpart
- python38Packages.notify
- python38Packages.pyblock
- python38Packages.pyqt5_with_qtwebkit

@bhipple bhipple merged commit fee7053 into NixOS:master Oct 30, 2020
16 checks passed
@ajs124 ajs124 deleted the drop/attica branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants