Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init libdatrie, libthai, ibus-engines.libthai; build pango with libthai #102122

Merged
merged 4 commits into from Nov 1, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Motivation for this change

Closes #68975

Build pango with libthai support.

Things done

This PR includes #102059 to be able to test pango on darwin.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000 SuperSandro2000 force-pushed the libthai branch 2 times, most recently from 01bb801 to 618c282 Oct 31, 2020
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 31, 2020

Rebased this onto nixos-unstable (sans the pango change) and confirmed in a VM that the IM works:

image

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Rebased this onto nixos-unstable (sans the pango change) and confirmed in a VM that the IM works:

Thanks! I admit that I did not try this which I probably should have done. Also thanks for the reviews.

Copy link
Contributor

@jtojnar jtojnar left a comment

Great job, thanks.

@jtojnar jtojnar merged commit 2785a1e into NixOS:staging Nov 1, 2020
19 checks passed
@SuperSandro2000 SuperSandro2000 deleted the libthai branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants