Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gojsontoyaml: init at unstable-2020-06-02 #102129

Merged
merged 1 commit into from Dec 8, 2020

Conversation

@bryanasdev000
Copy link
Member

@bryanasdev000 bryanasdev000 commented Oct 30, 2020

Motivation for this change

Add gojsontoyaml, a simply tool to convert json to yaml and vice-versa written in Go.

NOTE: In the project's Github there is no tag (release) so I'm using the last commit from the master.

Things done

Added package definition at pkgs/development/tools/gojsontoyaml/default.nix and added a reference line to pkgs/top-level/all-packages.nix below gjo.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102129 run on x86_64-linux 1

1 package built:
  • gojsontoyaml

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gojsontoyaml/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gojsontoyaml/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gojsontoyaml/default.nix Outdated Show resolved Hide resolved
Copy link
Member Author

@bryanasdev000 bryanasdev000 left a comment

Resolved the changes proposed by @kalbasit and @SuperSandro2000.
Thanks for the atention.

pkgs/development/tools/gojsontoyaml/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/gojsontoyaml/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@bryanasdev000 bryanasdev000 force-pushed the package-gojsontoyaml branch from 844feaf to c72a3a1 Nov 29, 2020
@bryanasdev000 bryanasdev000 changed the title gojsontoyaml: init at 3697ded gojsontoyaml: init at unstable-2020-06-02 Nov 29, 2020
Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
@bryanasdev000 bryanasdev000 force-pushed the package-gojsontoyaml branch from c72a3a1 to 6493ef3 Nov 29, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 102129 run on x86_64-linux 1

1 package built:
  • gojsontoyaml

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 102129 run on x86_64-darwin 1

1 package built:
  • gojsontoyaml

@SuperSandro2000 SuperSandro2000 merged commit 01b840b into NixOS:master Dec 8, 2020
19 checks passed
@bryanasdev000 bryanasdev000 deleted the package-gojsontoyaml branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants