Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncplay: 1.6.5 -> 1.6.6 #102130

Merged
merged 1 commit into from Nov 5, 2020
Merged

syncplay: 1.6.5 -> 1.6.6 #102130

merged 1 commit into from Nov 5, 2020

Conversation

@rileyinman
Copy link
Contributor

@rileyinman rileyinman commented Oct 30, 2020

Motivation for this change

New update available, 1.6.6 fixes an issue with 1.6.5 that could cause failures to connect in certain situations (Syncplay/syncplay#321).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@braunse
Copy link
Contributor

@braunse braunse commented Oct 30, 2020

Result of nixpkgs-review pr 102130 1

1 package built:
  • syncplay

euank
euank approved these changes Nov 1, 2020
Copy link
Contributor

@euank euank left a comment

👍

I can verify it built/worked locally on nixos, and it also indeed helped with a connectivity issue present in 1.6.5.

@mweinelt mweinelt merged commit b4e0721 into NixOS:master Nov 5, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
syncplay, syncplay.passthru.tests on aarch64-linux Timed out, unknown build status
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c79ef4e"; rev="c79ef4eacf367f85f36aa194a2e0a2d1abb3117c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c79ef4e"; rev="c79ef4eacf367f85f36aa194a2e0a2d1abb3117c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c79ef4e"; rev="c79ef4eacf367f85f36aa194a2e0a2d1abb3117c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c79ef4e"; rev="c79ef4eacf367f85f36aa194a2e0a2d1abb3117c"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c79ef4e"; rev="c79ef4eacf367f85f36aa194a2e0a2d1abb3117c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c79ef4e"; rev="c79ef4eacf367f85f36aa194a2e0a2d1abb3117c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c79ef4e"; rev="c79ef4eacf367f85f36aa194a2e0a2d1abb3117c"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
syncplay, syncplay.passthru.tests on x86_64-linux Success
Details
@rileyinman rileyinman deleted the syncplay-1.6.6 branch Nov 6, 2020
@Infinisil
Copy link
Member

@Infinisil Infinisil commented Jan 27, 2021

The update to 1.6.6 isn't what fixes the issue, it's the pyside2 5.15.1 update in #100752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants