Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step-ca 0.15.5 #102131

Closed
wants to merge 10 commits into from
Closed

Add step-ca 0.15.5 #102131

wants to merge 10 commits into from

Conversation

@dsx
Copy link
Contributor

@dsx dsx commented Oct 30, 2020

Motivation for this change
Things done
  • [×] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [×] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [×] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [×] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/tools/security/step-ca/0.15.nix Show resolved Hide resolved
pkgs/tools/security/step-ca/0.15.nix Show resolved Hide resolved
pkgs/tools/security/step-ca/0.15.nix Outdated Show resolved Hide resolved
pkgs/tools/security/step-ca/0.15.nix Outdated Show resolved Hide resolved
@@ -0,0 +1,42 @@
{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }:
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 25, 2020

Suggested change
{ lib, buildGoModule, buildGoPackage, fetchFromGitHub }:
{ lib, buildGoModule, fetchFromGitHub }:

let
sha256 = "01y4wi6j1frfpd6ndwrxw4sr9rwhj8m96mvp76rnszzwgvlydgd4";
vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5";
version = "0.15.5";
in
buildGoModule {
inherit vendorSha256;
inherit version;
pname = "step-ca";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 25, 2020

Suggested change
let
sha256 = "01y4wi6j1frfpd6ndwrxw4sr9rwhj8m96mvp76rnszzwgvlydgd4";
vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5";
version = "0.15.5";
in
buildGoModule {
inherit vendorSha256;
inherit version;
pname = "step-ca";
buildGoModule rec {
version = "0.15.5";
pname = "step-ca";

pname = "step-ca";

src = fetchFromGitHub {
inherit sha256;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 25, 2020

Suggested change
inherit sha256;
sha256 = "1zr78p2jxhajqv59kwqqq02njzr4s20ddixyh2ki95p6afniw7wp";

rev = "v${version}";
};

goPackagePath = "github.com/smallstep/certificates";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 25, 2020

Suggested change
goPackagePath = "github.com/smallstep/certificates";
goPackagePath = "github.com/smallstep/certificates";
vendorSha256 = "1is4rvga3anmzqqd1bmdw3014lxrvnm19jrfpyvmdqh7pc7cm4i5";


buildPhase = ''
runHook preBuild
CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 25, 2020

Suggested change
CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca
CGO_ENABLED=0 go build -v -o bin/step-ca -ldflags='-w -X "main.Version=${version}" -X "main.BuildTime=1969-12-31 23:59 UTC"' github.com/smallstep/certificates/cmd/step-ca
runHook postBuild

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Why did you not update the 0.13.X version?

@dsx
Copy link
Contributor Author

@dsx dsx commented Nov 27, 2020

I haven't read step-ca change log.

@AluisioASG
Copy link
Contributor

@AluisioASG AluisioASG commented Dec 21, 2020

Is this still being worked on?

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Please squash the commits and change PR and commit title to step-ca: init at 0.15.5

@mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Jan 24, 2021

@dsx I don't understand but isn't this version already in master? https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/step-ca/default.nix

@AluisioASG
Copy link
Contributor

@AluisioASG AluisioASG commented Jan 24, 2021

I don't understand but isn't this version already in master? https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/security/step-ca/default.nix

Indeed, looks like it's covered by #93711.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jan 25, 2021

Good catch! Closing as duplicate. Maybe we want to add an alias for this?

@mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Jan 25, 2021

@SuperSandro2000 There already exist step-ca and step-cli (https://github.com/NixOS/nixpkgs/tree/master/pkgs/tools/security) so I think it's fine. These are two tools from the smallstep organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants