Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscli2: 2.0.54 -> 2.0.61 #102134

Closed
wants to merge 1 commit into from
Closed

awscli2: 2.0.54 -> 2.0.61 #102134

wants to merge 1 commit into from

Conversation

@dbirks
Copy link
Member

@dbirks dbirks commented Oct 30, 2020

Motivation for this change

Updating to the version released today.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Updating to the version released today.
@@ -29,13 +29,13 @@ let
in
with py.pkgs; buildPythonApplication rec {
pname = "awscli2";
version = "2.0.54"; # N.B: if you change this, change botocore to a matching version too
version = "2.0.61"; # N.B: if you change this, change botocore to a matching version too
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 30, 2020

Shouldn't botcore also be updated?

Copy link
Member Author

@dbirks dbirks Oct 30, 2020

I think botocore is still on a 1.x.x release (link here) to match the current awscli v1.

N.B: if you change this, change botocore to a matching version too

I believe this is a note to change the version in the override at the top, to match what v2 of the aws-cli currently requires (link) ✌️

Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 30, 2020

Can we maybe clarify this that the overwrite in the top is meant?

@arcnmx
Copy link
Member

@arcnmx arcnmx commented Nov 17, 2020

Looks like colorama needs overriding to <0.4.4, also it looks like there's a 2.1 version now

@davegallant davegallant mentioned this pull request Nov 21, 2020
10 tasks
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 23, 2020

Superseded by #104453. Closing.

@dbirks dbirks deleted the update/awscli2 branch Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants