Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlangR23: 23.1 -> 23.1.1 #102135

Closed
wants to merge 1 commit into from
Closed

erlangR23: 23.1 -> 23.1.1 #102135

wants to merge 1 commit into from

Conversation

@braunse
Copy link
Contributor

@braunse braunse commented Oct 30, 2020

Motivation for this change

Upstream release: https://github.com/erlang/otp/releases/tag/OTP-23.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@braunse
Copy link
Contributor Author

@braunse braunse commented Oct 30, 2020

Result of nixpkgs-review pr 102135 1

1 package built:
  • erlangR23

@braunse
Copy link
Contributor Author

@braunse braunse commented Oct 30, 2020

Closure size difference:

/nix/store/60cl373d5d5f741cvs7m2akj5hv1sdmq-erlang-23.1           616544448 # before
/nix/store/x2nhr912cn7rih1hav9dl260hdgqv190-erlang-23.1.1         616579872 # after

@braunse
Copy link
Contributor Author

@braunse braunse commented Oct 30, 2020

Result of nixpkgs-review pr 102127 run on x86_64-darwin 1

Should this comment be in another PR? This is not #102127.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102127 run on x86_64-darwin 1

Should this comment be in another PR? This is not #102127.

You are totally right. Sorry about that. I deleted the comment and will rerun nixpkgs-review.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102135 run on x86_64-darwin 1

1 package built:
  • erlangR23

@braunse
Copy link
Contributor Author

@braunse braunse commented Nov 5, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 5, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@braunse
Copy link
Contributor Author

@braunse braunse commented Nov 8, 2020

Obsolete, OTP 23.1.2 was released: #103111

@braunse braunse closed this Nov 8, 2020
@braunse braunse deleted the erlang-23-1-1 branch Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants