Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remarkable-toolchain: use which instead of patching with sed #102136

Merged
merged 1 commit into from Dec 11, 2020

Conversation

@siraben
Copy link
Member

@siraben siraben commented Oct 30, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

I don't think the commit title matches that well but I don't any better right now.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 11, 2020

Fails to build with

unpacking sources
unpacking source archive /nix/store/rwnpam335zr38wdx5kv00w54d89l7fvh-oecore-x86_64-cortexa9hf-neon-toolchain-zero-gravitas-1.8-23.9.2019.sh
do not know how to unpack source archive /nix/store/rwnpam335zr38wdx5kv00w54d89l7fvh-oecore-x86_64-cortexa9hf-neon-toolchain-zero-gravitas-1.8-23.9.2019.sh

@siraben siraben force-pushed the remarkable-which branch from 6e981a0 to 12d1b76 Dec 11, 2020
@siraben
Copy link
Member Author

@siraben siraben commented Dec 11, 2020

Result of nixpkgs-review pr 102136 run on x86_64-linux 1

1 package built:
  • remarkable-toolchain

@siraben siraben requested a review from SuperSandro2000 Dec 11, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 11, 2020

Result of nixpkgs-review pr 102136 run on x86_64-linux 1

1 package built:
  • remarkable-toolchain

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 11, 2020

Result of nixpkgs-review pr 102136 run on x86_64-darwin 1

@SuperSandro2000 SuperSandro2000 merged commit e68a4f8 into NixOS:master Dec 11, 2020
19 checks passed
@FRidh
Copy link
Member

@FRidh FRidh commented Dec 11, 2020

What's the motivation for switching to Python 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants