Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klipper: 0.8.0 -> 0.9.1 #102143

Merged
merged 1 commit into from Nov 26, 2020
Merged

klipper: 0.8.0 -> 0.9.1 #102143

merged 1 commit into from Nov 26, 2020

Conversation

@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Oct 30, 2020

Motivation for this change

Noticed a new release was made.

cc. @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flokli
Copy link
Contributor

@flokli flokli commented Oct 30, 2020

did anything change w.r.t. the funky way this is packaged? Is there an upstream issue about it?

@lovesegfault
Copy link
Member Author

@lovesegfault lovesegfault commented Oct 30, 2020

did anything change w.r.t. the funky way this is packaged? Is there an upstream issue about it?

It didn't, it's still funky.

I'll open an issue upstream asking for a normal setup.py to see if we can make this less weird.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 102143 run on x86_64-linux 1

1 package built:
  • klipper

@SuperSandro2000 SuperSandro2000 merged commit f21a35d into NixOS:master Nov 26, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants