Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-shell-extension-pop-shell: init at 1.0.0 #102150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Oct 30, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Commit message should have init at not @

@worldofpeace worldofpeace requested a review from Oct 30, 2020
@Synthetica9 Synthetica9 changed the title gnome-shell-extension-pop-shell: init @ 1.0.0 gnome-shell-extension-pop-shell: init at 1.0.0 Nov 1, 2020
@Synthetica9
Copy link
Member Author

@Synthetica9 Synthetica9 commented Nov 1, 2020

Commit message should have init at not @

The commit message already had that, it was only the pr title that didn't. Changed it

@buckley310 buckley310 mentioned this pull request Nov 20, 2020
10 tasks
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Can you please squash the commits together?

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

please fix the eval error.

pkgs/desktops/gnome-3/extensions/pop-shell/default.nix Outdated Show resolved Hide resolved
@Synthetica9
Copy link
Member Author

@Synthetica9 Synthetica9 commented Mar 30, 2021

@grahamc Wait, there was already a PR. Anyways; these are the extensions they use. I updated them to the latest version but can't test that atm since I don't have a Gnome setup (same reason I removed myself as maintainer).

license = licenses.gpl3;
maintainers = with maintainers; [ ];
Copy link
Member

@SuperSandro2000 SuperSandro2000 Mar 31, 2021

gpl3Only or gpl3Plus? Maintainer needs to be set.


postInstall = ''
mv $out/usr/* $out
rmdir $out/usr
Copy link
Contributor

@benneti benneti Mar 31, 2021

if you add makeFlags = [ "XDG_DATA_HOME=$(out)/share" ]; you don't need to move the files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants