Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

palemoon: 28.14.2 -> 28.15.0 #102154

Merged

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 30, 2020

Motivation for this change

Simple version bump. Project changed its repo page to https://repo.palemoon.org/MoonchildProductions/Pale-Moon/releases, overriding fetchFromGitHub's githubBase seemed to work well enough, though it may not be the ideal/intended way of doing this.

· Security issues fixed: CVE-2020-15680 (VG-VD-20-115) and several memory safety hazards.
· Unified XUL Platform Mozilla Security Patch Summary: 1 fixed, 2 defense-in-depth, 12 not applicable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102154 run on x86_64-linux 1

1 package built:
  • palemoon

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 3, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/276

@SuperSandro2000 SuperSandro2000 merged commit 3cbb893 into NixOS:master Nov 25, 2020
19 checks passed
@OPNA2608
Copy link
Contributor Author

@OPNA2608 OPNA2608 commented Nov 30, 2020

Backport to 20.09: #105431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants