Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ptouch-print: init at 1.4.3 #102155

Merged
merged 1 commit into from Dec 28, 2020
Merged

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented Oct 30, 2020

Motivation for this change

#101712

Things done

Packaged ptouch-print release 1.4.3

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@luc65r luc65r left a comment

You don't need lib in the arguments

- { lib
- , stdenv
+ { stdenv
- meta = with lib; {
+ meta = with stdenv.lib; {

This makes it easier to add other maintainers later

- maintainers = [ maintainers.shamilton ];
+ maintainers = with maintainers; [ shamilton ];

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102155 run on x86_64-linux 1

1 package built:
  • ptouch-print

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 102155 run on x86_64-linux 1

1 package built:
  • ptouch-print

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 28, 2020

Result of nixpkgs-review pr 102155 run on x86_64-linux 1

1 package built:
  • ptouch-print

@SuperSandro2000 SuperSandro2000 merged commit a08cfe7 into NixOS:master Dec 28, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants