Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon-glacier-cmd-interface: remove package #102163

Merged
merged 1 commit into from Oct 30, 2020
Merged

Conversation

@mkenigs
Copy link
Contributor

@mkenigs mkenigs commented Oct 30, 2020

Last real upstream activity appears to be ~6 years ago and depends on
python2 packages that will soon be vulnerable

Helps #101964

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 30, 2020

for removal of top-level attrs, we usually add an entry to pkgs/top-level/aliases.nix which will thrown error.

I think we should say something like:

amazon-glacier-cmd-interface has been removed due to it being unmaintained

Which is true, if it was python3, we wouldn't be doing this.

cc @jtojnar

Last real upstream activity appears to be ~6 years ago and depends on
python2 packages that will soon be vulnerable

Helps NixOS#101964
@mkenigs mkenigs force-pushed the rm-glacier-cmd branch from eaeebf6 to b5faf8e Oct 30, 2020
@mkenigs
Copy link
Contributor Author

@mkenigs mkenigs commented Oct 30, 2020

Added an alias!

@jtojnar jtojnar merged commit 3d37920 into NixOS:master Oct 30, 2020
16 checks passed
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 30, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants