Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxstopmotion: 0.8.0 -> 0.8.5 #102165

Merged
merged 1 commit into from Oct 30, 2020
Merged

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 30, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Oct 30, 2020

@ajs124 Do you want to test it before merge? (All PR checkboxes are unchecked.)

@ajs124
Copy link
Member Author

@ajs124 ajs124 commented Oct 30, 2020

I built and ran it (on NixOS), but didn't actually create a movie with it, so I'm not sure if it works :P

@bjornfor bjornfor merged commit 0126c86 into NixOS:master Oct 30, 2020
19 checks passed
@bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Oct 30, 2020

Thanks!

@ajs124 ajs124 deleted the upd/linuxstopmotion branch Oct 30, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102165 run on x86_64-linux 1

1 package built:
  • linuxstopmotion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants