Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon-image: random.trust_cpu=on to cut 10s from boot #102175

Merged
merged 1 commit into from Oct 30, 2020

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Oct 30, 2020

Motivation for this change

Ubuntu and other distros already have this set via kernel config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Ubuntu and other distros already have this set via kernel config.
@samueldr
Copy link
Member

@samueldr samueldr commented Oct 30, 2020

Details:

As you won't find it as command line argument if it's in use in many other distros.

The change here makes it user-selectable without having to change the kernel in use.

@grahamc grahamc merged commit 860a3a2 into NixOS:master Oct 30, 2020
16 checks passed
@grahamc grahamc deleted the ami-random branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants