Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: 1.22.0 -> 1.22.1 #102177

merged 1 commit into from Oct 31, 2020

matrix-synapse: 1.22.0 -> 1.22.1 #102177

merged 1 commit into from Oct 31, 2020


Copy link

@Ma27 Ma27 commented Oct 30, 2020

Motivation for this change

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
fadenb approved these changes Oct 30, 2020
Copy link

@fadenb fadenb left a comment

Using the same change locally for a few hours now. Seems OK.

Copy link

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102177 run on x86_64-darwin 1

1 package failed to build:
  • matrix-synapse

Edit: The package rebuilds locally just fine. I don't quite understand the failure.

@Ma27 Ma27 merged commit b18d189 into NixOS:master Oct 31, 2020
19 of 20 checks passed
@Ma27 Ma27 deleted the bump-matrix-synapse branch Oct 31, 2020
Copy link
Member Author

@Ma27 Ma27 commented Oct 31, 2020

20.03: 050b006
20.09: 190e162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants