Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler: 1.10.3 -> 1.12.2 #102181

Merged
merged 1 commit into from Nov 8, 2020
Merged

wrangler: 1.10.3 -> 1.12.2 #102181

merged 1 commit into from Nov 8, 2020

Conversation

@bbigras
Copy link
Contributor

@bbigras bbigras commented Oct 30, 2020

Motivation for this change
Things done

For some reason, openssl-sys needed perl.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/v7318biarm49m6z6p5bf11595qi5md5d-wrangler-1.10.3 49.7M
/nix/store/fmvplgb2vmdxh32dzw9nmfn6s38icdqr-wrangler-1.12.1 51.7M

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102181 run on x86_64-linux 1

1 package built:
  • wrangler

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102181 run on x86_64-darwin 1

1 package failed to build:
  • wrangler
   Compiling semver-parser v0.10.1
   Compiling quote v1.0.7
   Compiling aho-corasick v0.7.14
   Compiling csv-core v0.1.10
   Compiling core-foundation v0.7.0
   Compiling security-framework-sys v0.4.3
   Compiling security-framework-sys v1.0.0
   Compiling regex-automata v0.1.9
error: failed to run custom build command for `openssl-sys v0.9.58`

Caused by:
  process didn't exit successfully: `/private/tmp/nix-build-wrangler-1.12.1.drv-0/source/target/release/build/openssl-sys-f4b8b7e4cd500fc7/build-script-main` (exit code: 101)
  --- stdout
  cargo:rustc-cfg=const_fn
  cargo:rerun-if-env-changed=X86_64_APPLE_DARWIN_OPENSSL_NO_VENDOR
  X86_64_APPLE_DARWIN_OPENSSL_NO_VENDOR unset
  cargo:rerun-if-env-changed=OPENSSL_NO_VENDOR
  OPENSSL_NO_VENDOR unset
  CC_x86_64-apple-darwin = Some("/nix/store/gkcr1p2x0psdc31bavmqbfb2nwq0d6jn-clang-wrapper-7.1.0/bin/cc")
  CFLAGS_x86_64-apple-darwin = None
  CFLAGS_x86_64_apple_darwin = None
  HOST_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2,sse3,ssse3")
  running "perl" "./Configure" "--prefix=/private/tmp/nix-build-wrangler-1.12.1.drv-0/source/target/x86_64-apple-darwin/release/build/openssl-sys-b9aab63630844977/out/openssl-build/install" "no-dso" "no-ssl3" "no-unit-test" "no-comp" "no-zlib" "no-zlib-dynamic" "no-md2" "no-rc5" "no-weak-ssl-ciphers" "no-camellia" "no-idea" "no-seed" "no-shared" "darwin64-x86_64-cc" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64"

  --- stderr
  thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /private/tmp/nix-build-wrangler-1.12.1.drv-0/wrangler-1.12.1-vendor.tar.gz/openssl-src/src/lib.rs:411:39
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Oct 31, 2020

@SuperSandro2000 could you please try again on darwin?

@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Oct 31, 2020

@GrahamcOfBorg build wrangler

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 1, 2020

Result of nixpkgs-review pr 102181 run on x86_64-darwin 1

1 package built:
  • wrangler

@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Nov 1, 2020

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 1, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/354

@bbigras bbigras changed the title wrangler: 1.10.3 -> 1.12.1 wrangler: 1.10.3 -> 1.12.2 Nov 3, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Nov 3, 2020

Fix issue which caused wrangler publish to nuke sites

https://github.com/cloudflare/wrangler/releases/tag/v1.12.2

updated to 1.12.2

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 8, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/361

Copy link
Member

@danieldk danieldk left a comment

Result of nixpkgs-review pr 102181 1

1 package built:
  • wrangler

LGTM and seems to work as expected.

@danieldk danieldk merged commit 4e9cb0a into NixOS:master Nov 8, 2020
19 checks passed
@bbigras bbigras deleted the wrangler branch Nov 8, 2020
@bbigras
Copy link
Contributor Author

@bbigras bbigras commented Nov 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants