Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmlsec: fix build in darwin sandbox, make tests (more) reproducible #102188

Closed
wants to merge 0 commits into from

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Motivation for this change
Error: failed to encrypt file "/tmp/testEnc.sh.20201030_201559-52277.tmp.3"
Error: failed to encrypt file with template "/private/tmp/nix-build-xmlsec-1.2.30.drv-0/xmlsec1-1.2.30/tests/nist-aesgcm/aes256/aes256-gcm-96-408-0-128-15.tmpl"
/private/tmp/nix-build-xmlsec-1.2.30.drv-0/xmlsec1-1.2.30/apps/xmlsec1 decrypt  --crypto openssl --crypto-config /tmp/xmlsec-crypto-config --keys-file /private/tmp/nix-build-xmlsec-1.2.30.drv-0/xmlsec1-1.2.30/tests/nist-aesgcm/keys-aes256-gcm.xml --output /tmp/testEnc.sh.20201030_201559-52277.tmp.2 /tmp/testEnc.sh.20201030_201559-52277.tmp
 I/O warning : failed to load external entity "/tmp/testEnc.sh.20201030_201559-52277.tmp"
func=xmlSecParseFile:file=parser.c:line=373:obj=unknown:subj=xmlCreateFileParserCtxt:error=5:libxml2 library function failed:filename=/tmp/testEnc.sh.20201030_201559-52277.tmp; xml error: 1549: failed to load external entity "/tmp/testEnc.sh.20201030_201559-52277.tmp

#102140 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102188 run on x86_64-linux 1

1 package marked as broken and skipped:
  • kmymoney
1 package failed to build:
  • lasso
6 packages built:
  • aqbanking
  • gnucash
  • matrix-synapse
  • python37Packages.pysaml2
  • python38Packages.pysaml2
  • xmlsec

lasso:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/bc6q4rglqyd0iw65r40hjgyyc20kgicr-lasso-2.6.1.tar.gz
source root is lasso-2.6.1
setting SOURCE_DATE_EPOCH to timestamp 1587573681 of file lasso-2.6.1/.tarball-version
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "autoreconfPhase" }
autoreconfPhase
Can't exec "/bin/sh": No such file or directory at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/share/autoconf/Autom4te/General.pm line 307.
Use of uninitialized value $Autom4te::General::tmp in scalar chomp at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/share/autoconf/Autom4te/General.pm line 309.
Can't exec "/bin/sh": No such file or directory at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 188.
Can't exec "/bin/sh": No such file or directory at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 189.
Use of uninitialized value $aclocal_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 190.
Use of uninitialized value $aclocal_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 191.
Use of uninitialized value $automake_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 192.
Use of uninitialized value $automake_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 193.
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I m4 --output=aclocal.m4t
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/x86_64-linux-thread-multi/IO/File.pm line 186.
aclocal: error: cannot open echo 'm4_define([m4_require_silent_probe], [-])' | /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autom4te --language Autoconf-without-aclocal-m4  - /nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/internal/ac-config-macro-dirs.m4 '/nix/store/vxfscsxa34n8wrvhkpdm1027rd5n92jf-pkg-config-wrapper-0.29.2/share/aclocal/pkg.m4' '/nix/store/2w7m5lj0dpc2gm7lvk73i2p0z6lgn5m0-libtool-2.4.6/share/aclocal/ltargz.m4' '/nix/store/2w7m5lj0dpc2gm7lvk73i2p0z6lgn5m0-libtool-2.4.6/share/aclocal/ltdl.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/amversion.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/auxdir.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/cond.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/depend.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/depout.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/init.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/install-sh.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/lead-dot.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/maintainer.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/make.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/missing.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/obsolete.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/options.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/prog-cc-c-o.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/runlog.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/sanity.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/silent.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/strip.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/substnot.m4' '/nix/store/ldr8z2wymypn63wg522r3s5zcl22dz93-automake-1.16.2/share/aclocal-1.16/tar.m4' 'm4/ac_check_class.m4' 'm4/ac_check_classpath.m4' 'm4/ac_check_junit.m4' 'm4/ac_prog_jar.m4' 'm4/ac_prog_java.m4' 'm4/ac_prog_java_works.m4' 'm4/ac_prog_javac.m4' 'm4/ac_prog_javac_works.m4' 'm4/ac_prog_javah.m4' 'm4/ac_try_compile_java.m4' 'm4/as-compiler-flag.m4' 'm4/dps_java_check_class.m4' 'm4/dps_xtra_classpath.m4' 'm4/gtk-doc.m4' 'm4/libtool.m4' 'm4/ltoptions.m4' 'm4/ltsugar.m4' 'm4/ltversion.m4' 'm4/lt~obsolete.m4' --trace='AC_DEFUN:$f::$n::${::}%' --trace='AC_DEFUN_ONCE:$f::$n::${::}%' --trace='AU_DEFUN:$f::$n::${::}%' --trace='_AM_AUTOCONF_VERSION:$f::$n::${::}%' --trace='AC_CONFIG_MACRO_DIR_TRACE:$f::$n::${::}%' --trace='AC_CONFIG_MACRO_DIR:$f::$n::${::}%' --trace='_AM_CONFIG_MACRO_DIRS:$f::$n::${::}%' --trace='AC_LTDL_SHLIBPATH:$f::$n' --trace='AC_PROG_JAR:$f::$n' --trace='PKG_CHECK_MODULES:$f::$n' --trace='LT_SYS_SYMBOL_USCORE:$f::$n' --trace='LT_AC_PROG_EGREP:$f::$n' --trace='AM_MISSING_HAS_RUN:$f::$n' --trace='AC_LIBTOOL_GCJ:$f::$n' --trace='_LT_PREPARE_SED_QUOTE_VARS:$f::$n' --trace='AC_DISABLE_FAST_INSTALL:$f::$n' --trace='AC_PATH_MAGIC:$f::$n' --trace='AC_DISABLE_STATIC:$f::$n' --trace='AC_LIBTOOL_SYS_OLD_ARCHIVE:$f::$n' --trace='AM_PROG_LD:$f::$n' --trace='AC_LIBTOOL_COMPILER_OPTION:$f::$n' --trace='_LT_AC_LANG_F77_CONFIG:$f::$n' --trace='LT_LANG:$f::$n' --trace='LT_AC_PROG_RC:$f::$n' --trace='AC_LIBTOOL_LANG_C_CONFIG:$f::$n' --trace='LT_LIB_M:$f::$n' --trace='AC_ENABLE_STATIC:$f::$n' --trace='_AM_OUTPUT_DEPENDENCY_COMMANDS:$f::$n' --trace='LTOBSOLETE_VERSION:$f::$n' --trace='AC_LTDL_SYSSEARCHPATH:$f::$n' --trace='AC_ENABLE_SHARED:$f::$n' --trace='AM_MAINTAINER_MODE:$f::$n' --trace='LT_SYS_DLSEARCH_PATH:$f::$n' --trace='AM_OUTPUT_DEPENDENCY_COMMANDS:$f::$n' --trace='AS_COMPILER_FLAGS:$f::$n' --trace='AC_LIBTOOL_LANG_CXX_CONFIG:$f::$n' --trace='LT_PROG_GCJ:$f::$n' --trace='AC_LIBTOOL_PROG_LD_HARDCODE_LIBPATH:$f::$n' --trace='AC_CHECK_JUNIT:$f::$n' --trace='AC_LIBTOOL_CONFIG:$f::$n' --trace='_LT_PROG_F77:$f::$n' --trace='_LT_AC_TAGVAR:$f::$n' --trace='AM_AUX_DIR_EXPAND:$f::$n' --trace='GTK_DOC_CHECK:$f::$n' --trace='_LT_AC_LANG_GCJ_CONFIG:$f::$n' --trace='_AM_SET_OPTIONS:$f::$n' --trace='_PKG_SHORT_ERRORS_SUPPORTED:$f::$n' --trace='_AM_SUBST_NOTMAKE:$f::$n' --trace='_LT_AC_SYS_LIBPATH_AIX:$f::$n' --trace='LT_AC_PROG_GCJ:$f::$n' --trace='AM_INIT_AUTOMAKE:$f::$n' --trace='_LT_AC_CHECK_DLFCN:$f::$n' --trace='AC_LIBTOOL_OBJDIR:$f::$n' --trace='AC_LIBTOOL_RC:$f::$n' --trace='AM_PROG_NM:$f::$n' --trace='AC_ENABLE_FAST_INSTALL:$f::$n' --trace='AC_LIBTOOL_DLOPEN:$f::$n' --trace='_LT_WITH_SYSROOT:$f::$n' --trace='AC_CHECK_LIBM:$f::$n' --trace='AM_CONFIG_HEADER:$f::$n' --trace='LT_SYS_MODULE_PATH:$f::$n' --trace='AC_LIBTOOL_SYS_DYNAMIC_LINKER:$f::$n' --trace='_AM_IF_OPTION:$f::$n' --trace='AM_PROG_CC_STDC:$f::$n' --trace='AC_LIBTOOL_CXX:$f::$n' --trace='LT_INIT:$f::$n' --trace='AM_PROG_CC_C_O:$f::$n' --trace='_LT_COMPILER_OPTION:$f::$n' --trace='LT_SYS_DLOPEN_DEPLIBS:$f::$n' --trace='AC_CHECK_CLASS:$f::$n' --trace='AC_WITH_LTDL:$f::$n' --trace='PKG_NOARCH_INSTALLDIR:$f::$n' --trace='AC_LIBTOOL_LANG_RC_CONFIG:$f::$n' --trace='_LT_AC_PROG_CXXCPP:$f::$n' --trace='_AM_PROG_CC_C_O:$f::$n' --trace='_LT_AC_PROG_ECHO_BACKSLASH:$f::$n' --trace='_AM_PROG_TAR:$f::$n' --trace='AS_COMPILER_FLAG:$f::$n' --trace='PKG_PROG_PKG_CONFIG:$f::$n' --trace='DPS_XTRA_CLASSPATH:$f::$n' --trace='AM_CONDITIONAL:$f::$n' --trace='_LT_AC_LOCK:$f::$n' --trace='LT_PATH_NM:$f::$n' --trace='AC_LIBTOOL_SETUP:$f::$n' --trace='AC_LIBTOOL_LANG_GCJ_CONFIG:$f::$n' --trace='_AC_AM_CONFIG_HEADER_HOOK:$f::$n' --trace='LT_CMD_MAX_LEN:$f::$n' --trace='AC_PROG_JAVAC_WORKS:$f::$n' --trace='AM_PROG_LIBTOOL:$f::$n' --trace='_LT_COMPILER_BOILERPLATE:$f::$n' --trace='AM_SANITY_CHECK:$f::$n' --trace='_LT_PATH_TOOL_PREFIX:$f::$n' --trace='DPS_JAVA_CHECK_CLASS:$f::$n' --trace='AM_PROG_INSTALL_SH:$f::$n' --trace='AC_LIBTOOL_SYS_HARD_LINK_LOCKS:$f::$n' --trace='LT_WITH_LTDL:$f::$n' --trace='LTDL_INSTALLABLE:$f::$n' --trace='LT_CONFIG_LTDL_DIR:$f::$n' --trace='PKG_CHECK_MODULES_STATIC:$f::$n' --trace='AC_LTDL_PREOPEN:$f::$n' --trace='_LT_PROG_FC:$f::$n' --trace='LT_FUNC_DLSYM_USCORE:$f::$n' --trace='AC_LTDL_SYS_DLOPEN_DEPLIBS:$f::$n' --trace='AC_LIBTOOL_DLOPEN_SELF:$f::$n' --trace='AC_LIBLTDL_CONVENIENCE:$f::$n' --trace='PKG_CHECK_VAR:$f::$n' --trace='LT_PATH_LD:$f::$n' --trace='AC_LIBTOOL_PROG_COMPILER_PIC:$f::$n' --trace='_LT_AC_LANG_CXX_CONFIG:$f::$n' --trace='AM_MISSING_PROG:$f::$n' --trace='AC_DISABLE_SHARED:$f::$n' --trace='PKG_CHECK_EXISTS:$f::$n' --trace='AM_SET_DEPDIR:$f::$n' --trace='LT_SYS_MODULE_EXT:$f::$n' --trace='AM_SET_CURRENT_AUTOMAKE_VERSION:$f::$n' --trace='_LT_AC_LANG_CXX:$f::$n' --trace='LT_OUTPUT:$f::$n' --trace='AM_SET_LEADING_DOT:$f::$n' --trace='_LT_DLL_DEF_P:$f::$n' --trace='AM_DISABLE_SHARED:$f::$n' --trace='AC_PROG_JAVA:$f::$n' --trace='AC_LIBLTDL_INSTALLABLE:$f::$n' --trace='AC_LIBTOOL_SYS_GLOBAL_SYMBOL_PIPE:$f::$n' --trace='LT_PROG_GO:$f::$n' --trace='AC_LIB_LTDL:$f::$n' --trace='_LT_LIBOBJ:$f::$n' --trace='_AC_PROG_LIBTOOL:$f::$n' --trace='AC_PROG_LD_GNU:$f::$n' --trace='AC_LIBTOOL_POSTDEP_PREDEP:$f::$n' --trace='_LT_AC_TAGCONFIG:$f::$n' --trace='_LT_AC_SYS_COMPILER:$f::$n' --trace='AC_PROG_JAVAH:$f::$n' --trace='AC_PROG_JAVA_WORKS:$f::$n' --trace='AM_SILENT_RULES:$f::$n' --trace='LT_SYS_DLOPEN_SELF:$f::$n' --trace='LT_AC_PROG_SED:$f::$n' --trace='LTDL_INIT:$f::$n' --trace='PKG_INSTALLDIR:$f::$n' --trace='_LT_PROG_CXX:$f::$n' --trace='LTDL_CONVENIENCE:$f::$n' --trace='AC_PROG_LIBTOOL:$f::$n' --trace='_LT_REQUIRED_DARWIN_CHECKS:$f::$n' --trace='AC_LTDL_DLSYM_USCORE:$f::$n' --trace='AC_LTDL_OBJDIR:$f::$n' --trace='AC_LIBTOOL_LINKER_OPTION:$f::$n' --trace='_LTDL_SETUP:$f::$n' --trace='AC_LIBTOOL_WIN32_DLL:$f::$n' --trace='AC_CHECK_CLASSPATH:$f::$n' --trace='_LT_AC_TRY_DLOPEN_SELF:$f::$n' --trace='AC_PROG_LD_RELOAD_FLAG:$f::$n' --trace='AC_LIBTOOL_FC:$f::$n' --trace='_LT_AC_LANG_C_CONFIG:$f::$n' --trace='AC_LTDL_ENABLE_INSTALL:$f::$n' --trace='AM_SUBST_NOTMAKE:$f::$n' --trace='_LT_LINKER_BOILERPLATE:$f::$n' --trace='AC_LTDL_SYMBOL_USCORE:$f::$n' --trace='_LT_AC_SHELL_INIT:$f::$n' --trace='_LT_AC_FILE_LTDLL_C:$f::$n' --trace='AC_PROG_EGREP:$f::$n' --trace='LTOPTIONS_VERSION:$f::$n' --trace='AC_LTDL_SHLIBEXT:$f::$n' --trace='LT_LIB_DLLOAD:$f::$n' --trace='AC_PROG_NM:$f::$n' --trace='AC_LIBTOOL_PROG_COMPILER_NO_RTTI:$f::$n' --trace='AC_LIBTOOL_PICMODE:$f::$n' --trace='AM_RUN_LOG:$f::$n' --trace='AM_C_PROTOTYPES:$f::$n' --trace='_LT_AC_LANG_RC_CONFIG:$f::$n' --trace='_AM_DEPENDENCIES:$f::$n' --trace='AC_PATH_TOOL_PREFIX:$f::$n' --trace='_LT_AC_LANG_GCJ:$f::$n' --trace='AC_LIBTOOL_F77:$f::$n' --trace='AM_PROG_INSTALL_STRIP:$f::$n' --trace='AC_LIBTOOL_PROG_LD_SHLIBS:$f::$n' --trace='LT_SUPPORTED_TAG:$f::$n' --trace='_AM_MANGLE_OPTION:$f::$n' --trace='LTVERSION_VERSION:$f::$n' --trace='AC_LIBTOOL_PROG_CC_C_O:$f::$n' --trace='_LT_PROG_ECHO_BACKSLASH:$f::$n' --trace='AC_TRY_COMPILE_JAVA:$f::$n' --trace='AC_PROG_LD:$f::$n' --trace='AC_LIBTOOL_SYS_MAX_CMD_LEN:$f::$n' --trace='_LT_LINKER_OPTION:$f::$n' --trace='AC_LIBTOOL_SYS_LIB_STRIP:$f::$n' --trace='LT_PROG_RC:$f::$n' --trace='AM_MAKE_INCLUDE:$f::$n' --trace='_AM_SET_OPTION:$f::$n' --trace='AM_DEP_TRACK:$f::$n' --trace='LTSUGAR_VERSION:$f::$n' --trace='AM_ENABLE_STATIC:$f::$n' --trace='LT_FUNC_ARGZ:$f::$n' --trace='_LT_PROG_LTMAIN:$f::$n' --trace='AC_PROG_JAVAC:$f::$n' --trace='AM_ENABLE_SHARED:$f::$n' --trace='AC_LIBTOOL_LANG_F77_CONFIG:$f::$n' --trace='_LT_AC_LANG_F77:$f::$n' --trace='fp_C_PROTOTYPES:$f::$n' --trace='AC_DEPLIBS_CHECK_METHOD:$f::$n' --trace='AM_AUTOMAKE_VERSION:$f::$n' --trace='AC_LTDL_DLLIB:$f::$n' --trace='_LT_CC_BASENAME:$f::$n' --trace='AM_DISABLE_STATIC:$f::$n' configure.ac |: No such file or directory
autoreconf: aclocal failed with exit status: 1

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 102188 run on x86_64-linux 1

8 packages built:
  • aqbanking
  • gnucash
  • kmymoney
  • lasso
  • matrix-synapse
  • python37Packages.pysaml2
  • python38Packages.pysaml2
  • xmlsec

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 102188 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • bareos
  • krunner-pass
6 packages built:
  • matrix-synapse
  • oathToolkit
  • passExtensions.pass-otp
  • python37Packages.pysaml2
  • python38Packages.pysaml2
  • xmlsec

@SuperSandro2000 SuperSandro2000 requested a review from doronbehar Nov 26, 2020
Copy link
Contributor

@doronbehar doronbehar left a comment

Indentation. Otherwise 👏.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Dec 23, 2020

Why close?

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Dec 24, 2020

The commit is already in master as part of another PR and github closed it when I rebased it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants