Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/sources.nix: fix incorrect inherit #102191

Merged
merged 1 commit into from Oct 30, 2020
Merged

lib/sources.nix: fix incorrect inherit #102191

merged 1 commit into from Oct 30, 2020

Conversation

@deviant
Copy link
Member

@deviant deviant commented Oct 30, 2020

split comes from builtins, not lib.

error: attribute 'split' missing, at /nix/path/nixpkgs/lib/sources.nix:4:4
(use '--show-trace' to show detailed location information)
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
split comes from builtins, not lib.

	error: attribute 'split' missing, at /nix/path/nixpkgs/lib/sources.nix:4:4
	(use '--show-trace' to show detailed location information)
@deviant deviant requested review from edolstra, Infinisil and nbp as code owners Oct 30, 2020
@Infinisil Infinisil merged commit 78782d3 into NixOS:master Oct 30, 2020
16 checks passed
@Infinisil
Copy link
Member

@Infinisil Infinisil commented Oct 30, 2020

Thanks!

@deviant deviant deleted the fix-inherit branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants