Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shfmt: 3.1.2 -> 3.2.0 #102192

Merged
merged 2 commits into from Oct 30, 2020
Merged

shfmt: 3.1.2 -> 3.2.0 #102192

merged 2 commits into from Oct 30, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Motivation for this change

Update got just released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

Result of nixpkgs-review pr 102192 run on x86_64-darwin 1

2 packages built:
  • bat-extras.prettybat
  • shfmt

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 30, 2020

Can you remove fetchpatch please?

diff --git a/pkgs/tools/text/shfmt/default.nix b/pkgs/tools/text/shfmt/default.nix
index c3f1bac59d5..694b1db58f5 100644
--- a/pkgs/tools/text/shfmt/default.nix
+++ b/pkgs/tools/text/shfmt/default.nix
@@ -1,4 +1,4 @@
-{ lib, buildGoModule, fetchFromGitHub, fetchpatch }:
+{ lib, buildGoModule, fetchFromGitHub }:
 
 buildGoModule rec {
   pname = "shfmt";

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 30, 2020

@SuperSandro2000 I've removed fetchpatch and pushed a commit installing the man page.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 30, 2020

@SuperSandro2000 I've removed fetchpatch and pushed a commit installing the man page.

God you are paying attention here. I actually removed it but did not commit it. Silly me.

@zowoq zowoq merged commit 1e20b2d into NixOS:master Oct 30, 2020
19 checks passed
@SuperSandro2000 SuperSandro2000 deleted the shfmt-3.2.0 branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants