Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.anyio: disable all socket-related tests on darwin #102193

Merged
merged 1 commit into from Nov 23, 2020

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 30, 2020

Motivation for this change

@SuperSandro2000 #99521

They don't work in their sandbox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102193 run on x86_64-darwin 1

4 packages failed to build:
  • python37Packages.anyio
  • python37Packages.ircrobots
  • python38Packages.anyio
  • python38Packages.ircrobots
=================================== FAILURES ===================================                                                                                                            ___________________ TestTLSStream.test_send_receive[asyncio] ___________________                                                                                                            tests/streams/test_tls.py:27: in test_send_receive                                                                                                                                              server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      _______________ TestTLSStream.test_send_receive[asyncio+uvloop] ________________                                                                                                            tests/streams/test_tls.py:27: in test_send_receive                                                                                                                                              server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      ____________________ TestTLSStream.test_send_receive[curio] ____________________                                                                                                            tests/streams/test_tls.py:27: in test_send_receive                                                                                                                                              server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      ____________________ TestTLSStream.test_send_receive[trio] _____________________                                                                                                            tests/streams/test_tls.py:27: in test_send_receive                                                                                                                                              server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      _________________ TestTLSStream.test_extra_attributes[asyncio] _________________
tests/streams/test_tls.py:55: in test_extra_attributes                                                                                                                            [90/45885]    server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      __________________ TestTLSStream.test_extra_attributes[trio] ___________________                                                                                                            tests/streams/test_tls.py:55: in test_extra_attributes                                                                                                                                          server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      ______________________ TestTLSStream.test_unwrap[asyncio] ______________________                                                                                                            tests/streams/test_tls.py:93: in test_unwrap                                                                                                                                                    server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      __________________ TestTLSStream.test_unwrap[asyncio+uvloop] ___________________                                                                                                            tests/streams/test_tls.py:93: in test_unwrap                                                                                                                                                    server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      _______________________ TestTLSStream.test_unwrap[curio] _______________________                                                                                                            tests/streams/test_tls.py:93: in test_unwrap                                                                                                                                                    server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      _______________________ TestTLSStream.test_unwrap[trio] ________________________                                                                                                            tests/streams/test_tls.py:93: in test_unwrap                                                                                                                                                    server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      _________________ TestTLSStream.test_alpn_negotiation[asyncio] _________________                                                                                                            tests/streams/test_tls.py:125: in test_alpn_negotiation                                                                                                                                         server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      _____________ TestTLSStream.test_alpn_negotiation[asyncio+uvloop] ______________                                                                                                            tests/streams/test_tls.py:125: in test_alpn_negotiation                                                                                                                                         server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      __________________ TestTLSStream.test_alpn_negotiation[curio] __________________                                                                                                            tests/streams/test_tls.py:125: in test_alpn_negotiation                                                                                                                                         server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      __________________ TestTLSStream.test_alpn_negotiation[trio] ___________________                                                                                                            tests/streams/test_tls.py:125: in test_alpn_negotiation                                                                                                                                         server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      ____________ TestTLSStream.test_ragged_eofs[asyncio-both_standard] _____________
tests/streams/test_tls.py:169: in test_ragged_eofs                                                                                                                                [10/45885]    server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      ____________ TestTLSStream.test_ragged_eofs[curio-neither_standard] ____________                                                                                                            tests/streams/test_tls.py:169: in test_ragged_eofs                                                                                                                                              server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      ______________ TestTLSStream.test_ragged_eofs[trio-both_standard] ______________                                                                                                            tests/streams/test_tls.py:169: in test_ragged_eofs                                                                                                                                              server_sock.bind(('127.0.0.1', 0))                                                                                                                                                      E   PermissionError: [Errno 1] Operation not permitted                                                                                                                                      _____________ TestTLSStream.test_ragged_eofs[trio-server_standard] _____________
tests/streams/test_tls.py:169: in test_ragged_eofs
    server_sock.bind(('127.0.0.1', 0))
E   PermissionError: [Errno 1] Operation not permitted
_____________ TestTLSStream.test_ragged_eofs[trio-client_standard] _____________
tests/streams/test_tls.py:169: in test_ragged_eofs
    server_sock.bind(('127.0.0.1', 0))
E   PermissionError: [Errno 1] Operation not permitted
____________ TestTLSStream.test_ragged_eofs[trio-neither_standard] _____________
tests/streams/test_tls.py:169: in test_ragged_eofs
    server_sock.bind(('127.0.0.1', 0))
E   PermissionError: [Errno 1] Operation not permitted
______________ TestTLSStream.test_receive_send_after_eof[asyncio] ______________
tests/streams/test_tls.py:199: in test_receive_send_after_eof
    server_sock.bind(('127.0.0.1', 0))
E   PermissionError: [Errno 1] Operation not permitted
__________ TestTLSStream.test_receive_send_after_eof[asyncio+uvloop] ___________
tests/streams/test_tls.py:199: in test_receive_send_after_eof
    server_sock.bind(('127.0.0.1', 0))
E   PermissionError: [Errno 1] Operation not permitted
_______________ TestTLSStream.test_receive_send_after_eof[curio] _______________
tests/streams/test_tls.py:199: in test_receive_send_after_eof
    server_sock.bind(('127.0.0.1', 0))
E   PermissionError: [Errno 1] Operation not permitted
_______________ TestTLSStream.test_receive_send_after_eof[trio] ________________
tests/streams/test_tls.py:199: in test_receive_send_after_eof
    server_sock.bind(('127.0.0.1', 0))
E   PermissionError: [Errno 1] Operation not permitted
=============================== warnings summary ===============================

@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Oct 31, 2020

Pushed a version disabling the correct file. Please retest.

@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Nov 17, 2020

Pushed a version disabling the correct file. Please retest.

@SuperSandro2000

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 23, 2020

Result of nixpkgs-review pr 102193 run on x86_64-darwin 1

4 packages built:
  • python37Packages.anyio
  • python37Packages.ircrobots
  • python38Packages.anyio
  • python38Packages.ircrobots

@SuperSandro2000 SuperSandro2000 merged commit bb8ed2f into NixOS:master Nov 23, 2020
17 checks passed
@mweinelt mweinelt deleted the python/anyio branch Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants