Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phd2: init at 2.6.9dev1 #102200

Merged
merged 1 commit into from Nov 26, 2020
Merged

phd2: init at 2.6.9dev1 #102200

merged 1 commit into from Nov 26, 2020

Conversation

@hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Oct 31, 2020

Motivation for this change

Add phd2 telescope guidance software to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102200 run on x86_64-linux 1

1 package built:
  • phd2

@hjones2199 hjones2199 force-pushed the master branch 2 times, most recently from 6eeb548 to 9503330 Oct 31, 2020
@hjones2199
Copy link
Member Author

@hjones2199 hjones2199 commented Oct 31, 2020

Thanks for the quick review. I pushed in the changes to meta, and moved cmake from buildInputs to nativeBuildInputs.

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/applications/science/astronomy/phd2/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/astronomy/phd2/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/astronomy/phd2/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 102200 run on x86_64-linux 1

1 package built:
  • phd2

@hjones2199 hjones2199 requested a review from SuperSandro2000 Nov 25, 2020
@SuperSandro2000 SuperSandro2000 merged commit 605ecee into NixOS:master Nov 26, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants