Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/murmur: add iniPath, config, user, group options #102224

Closed
wants to merge 4 commits into from

Conversation

@Uthar
Copy link
Contributor

@Uthar Uthar commented Oct 31, 2020

Motivation for this change

Make it possible to provide a password through NixOps's deployment.keys

deployment.keys = with lib; {
      murmurIni.text = ''
      ${config.services.murmur.config}
      serverpassword=${readFile ./keys/murmurPassword}
      '';
};

services.murmur = {
  iniPath = "/run/keys/murmurIni";
  group = "keys";
};
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Uthar added 2 commits Oct 31, 2020
because I want to provide murmur.ini with NixOps's deployment.keys to
keep the password out of /nix/store.
@Uthar Uthar changed the title Add services.murmur options: iniPath, config, user, group nixos/murmur: add iniPath, config, user, group options Oct 31, 2020
@Uthar
Copy link
Contributor Author

@Uthar Uthar commented Oct 31, 2020

nvm, closing
I made these changes before commit 533560d, which added support for using EnvironmentFile in murmurd.service. That's much less hacky.

@Uthar Uthar closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant