Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim: revert change to extraMakeWrapperArgs #102231

Merged
merged 2 commits into from Oct 31, 2020
Merged

neovim: revert change to extraMakeWrapperArgs #102231

merged 2 commits into from Oct 31, 2020

Conversation

@teto
Copy link
Contributor

@teto teto commented Oct 31, 2020

The changes in #101265 changed wrapNeovim to incite users to use a list instead of a string for extraMakeWrapperArgs. This reverts that since the change is not super useful (also I want the wrapper to be low-level so passing a string may actually make more sense) while breaking home-manager see nix-community/home-manager#1577
@SenchoPens does that fix your issue ?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
wrapNeovim incited users to use a list instead of a string. Revert that:
the change is not super useful while breaking home-manager.
the compatibility layer for `wrapNeovim` introduced in NixOS#101265
broke the recommended way of configuration:
https://nixos.org/manual/nixpkgs/stable/#custom-configuration
https://nixos.wiki/wiki/Vim#Customizations

restore the old ways.
@beardhatcode
Copy link
Contributor

@beardhatcode beardhatcode commented Oct 31, 2020

@teto, The same problem (nix-community/home-manager#1577) cropped up for me today. This fixes it for me
(nikpkgs @ db15722 and home-manager @ a98ec6e)

Thanks 👍

LnL7
LnL7 approved these changes Oct 31, 2020
Copy link
Member

@LnL7 LnL7 left a comment

I haven't been following the wrapper changes specifically, but this restores the current behaviour.

If you think the new approach should be encouraged the example is the manual should also be updated. Along with maybe some kind of warning when the fallback is used.

@teto
Copy link
Contributor Author

@teto teto commented Oct 31, 2020

sure. New wrapper is still a work in progress so I will wait for its interface to stabilize before updating these. Merging then and sorry for the annoyance.

@teto teto merged commit 36ac62c into NixOS:master Oct 31, 2020
17 checks passed
@teto teto deleted the neovim_fix branch Oct 31, 2020
@LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 31, 2020

Alright, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants