Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tlp: Fix deprecation hint #102237

Merged
merged 1 commit into from Nov 1, 2020
Merged

nixos/tlp: Fix deprecation hint #102237

merged 1 commit into from Nov 1, 2020

Conversation

@oxzi
Copy link
Member

@oxzi oxzi commented Oct 31, 2020

Motivation for this change

The deprecated extraConfig option refers to the config option, which does not exists. The settings option should be used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The deprecated extraConfig option refers to the config option, which
does not exists. The settings option should be used.
@oxzi oxzi requested a review from Mic92 Oct 31, 2020
@Mic92 Mic92 merged commit 7b5cebf into NixOS:master Nov 1, 2020
17 checks passed
@oxzi oxzi deleted the tlp-deprecation-note branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants