Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit: 1.19.0 -> 1.20.0 #102240

Merged
merged 1 commit into from Nov 2, 2020
Merged

unit: 1.19.0 -> 1.20.0 #102240

merged 1 commit into from Nov 2, 2020

Conversation

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 31, 2020

Motivation for this change

Update unit to 1.20.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102240 run on x86_64-linux 1

1 package built:
  • unit

stigtsp
stigtsp approved these changes Nov 2, 2020
Copy link
Member

@stigtsp stigtsp left a comment

LGTM

Built OK on linux x64

Did very basic test of unitd

unitd --no-daemon --log /tmp/unit.log --state /tmp --control unix:/tmp/unit.sock

Result of nixpkgs-review pr 102240 1

1 package built:
  • unit

@stigtsp stigtsp merged commit 818f2dd into NixOS:master Nov 2, 2020
19 of 20 checks passed
@Izorkin Izorkin deleted the nginx-unit branch Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants