Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vivaldi: 3.3.2022.47-1 -> 3.4.2066.90-1 #102245

merged 1 commit into from Nov 15, 2020

vivaldi: 3.3.2022.47-1 -> 3.4.2066.90-1 #102245

merged 1 commit into from Nov 15, 2020


Copy link

@badmutex badmutex commented Oct 31, 2020

Motivation for this change

vivaldi bump

Things done

pr submitted via on latest vivaldi :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Copy link

@matklad matklad commented Nov 3, 2020

Confirmed that it builds and works on NixOS unstable!

Copy link

@jdnixx jdnixx commented Nov 14, 2020

Does there need to be something else done before this is merged?

Copy link
Contributor Author

@badmutex badmutex commented Nov 15, 2020

no. it just needs to be merged but i don't have write access

@romildo romildo merged commit cba35cb into NixOS:master Nov 15, 2020
19 checks passed
@badmutex badmutex deleted the patch-1 branch Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants