Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndn-cxx: 0.6.3 -> 0.7.1 #102248

Merged
merged 1 commit into from Nov 1, 2020
Merged

ndn-cxx: 0.6.3 -> 0.7.1 #102248

merged 1 commit into from Nov 1, 2020

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Oct 31, 2020

Motivation for this change

Version update, package cleanup (part of #101964)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102248 run on x86_64-linux 1

1 package built:
  • ndn-cxx

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102248 run on x86_64-darwin 1

1 package failed to build:
  • ndn-cxx
unpacking sources
unpacking source archive /nix/store/fmd4zhhgh98qggk20yzb9a45nrk07m5p-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
configure flags: --prefix=/nix/store/2xlvvz7d447v8n6kk6ssif7b8fvmh6bq-ndn-cxx-0.7.1 --with-openssl=/nix/store/bid8wmf6fb5kg702ywnl7zjzh5158dnr-openssl-1.1.1g-dev --boost-includes=/nix/store/njymq44zr2yijwvlb5pc6d2blxpk5lak-boost-1.69.0-dev/include --boost-libs=/nix/store/5c1l3jplzwcs0k6adqvlksk46i62c8gi-boost-1.69.0/lib configure
Setting top to                           : /private/tmp/nix-build-ndn-cxx-0.7.1.drv-0/source
Setting out to                           : /private/tmp/nix-build-ndn-cxx-0.7.1.drv-0/source/build
Building static library                  : no
Building shared library                  : yes
Checking for 'clang++' (C++ compiler)    : clang++
Checking C++ compiler version            : 7.1.0
The version of Xcode you are using is too old.
The minimum supported Xcode version is 9.0.
(complete log in /private/tmp/nix-build-ndn-cxx-0.7.1.drv-0/source/build/config.log)

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 102248 1

1 package built:
  • ndn-cxx

@jonringer jonringer merged commit ec4c848 into NixOS:master Nov 1, 2020
19 of 20 checks passed
@prusnak prusnak deleted the ndn-cxx branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants