Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/firefox: add audio subtest #102249

Merged
merged 1 commit into from Oct 31, 2020
Merged

nixos/tests/firefox: add audio subtest #102249

merged 1 commit into from Oct 31, 2020

Conversation

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 31, 2020

Motivation for this change

Avoid issue #79310 happening again.

This PR adds a very basic but useful sound check: it sets up a loopback device
as default audio output and records any sound. Then plays a sample sound using
firefox and checks if the sound is recorded back.

Things done
  • Tested audio currently works
  • Tested it can detect audio didn't work before #101314
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@cole-h cole-h left a comment

Test runs successfully, generates result/screen.png and result/record.wav (which does indeed play the "phone ringing" sound).

nixos/tests/firefox.nix Outdated Show resolved Hide resolved
andir
andir approved these changes Oct 31, 2020
Copy link
Member

@andir andir left a comment

This is amazing! Thank you very much!

Can you also fix the mentioned type annotation that @cole-h pointed out?

cole-h
cole-h approved these changes Oct 31, 2020
nixos/tests/firefox.nix Show resolved Hide resolved
@andir andir merged commit fd0b383 into NixOS:master Oct 31, 2020
16 checks passed
16 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7904ca"; rev="f7904ca45b9cb9e9cec61d090e66d7207ab6d422"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7904ca"; rev="f7904ca45b9cb9e9cec61d090e66d7207ab6d422"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7904ca"; rev="f7904ca45b9cb9e9cec61d090e66d7207ab6d422"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7904ca"; rev="f7904ca45b9cb9e9cec61d090e66d7207ab6d422"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7904ca"; rev="f7904ca45b9cb9e9cec61d090e66d7207ab6d422"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7904ca"; rev="f7904ca45b9cb9e9cec61d090e66d7207ab6d422"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f7904ca"; rev="f7904ca45b9cb9e9cec61d090e66d7207ab6d422"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants