Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julius: 1.4.1 -> 1.5.1 #102263

Merged
merged 1 commit into from Nov 26, 2020
Merged

julius: 1.4.1 -> 1.5.1 #102263

merged 1 commit into from Nov 26, 2020

Conversation

@Thra11
Copy link
Contributor

@Thra11 Thra11 commented Oct 31, 2020

Motivation for this change

Package version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102263 run on x86_64-linux 1

1 package built:
  • julius

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 1, 2020

Result of nixpkgs-review pr 102263 run on x86_64-darwin 1

1 package failed to build:
  • julius
[ 37%] Building C object test/CMakeFiles/autopilot.dir/__/src/scenario/request.c.o
[ 38%] Building C object test/CMakeFiles/autopilot.dir/__/src/sound/city.c.o
[ 38%] Building C object test/CMakeFiles/autopilot.dir/__/src/sound/effect.c.o
[ 38%] Building C object test/CMakeFiles/autopilot.dir/__/src/sound/music.c.o
[ 38%] Building C object test/CMakeFiles/autopilot.dir/__/src/sound/speech.c.o
[ 38%] Building C object test/CMakeFiles/autopilot.dir/__/src/sound/system.c.o
[ 39%] Building C object test/CMakeFiles/autopilot.dir/__/src/editor/editor.c.o
[ 39%] Building C object test/CMakeFiles/autopilot.dir/__/src/editor/tool.c.o
[ 39%] Building C object test/CMakeFiles/autopilot.dir/__/src/editor/tool_restriction.c.o
[ 39%] Linking C executable autopilot
ld: warning: passed two min versions (10.10.0, 10.12) for platform macOS. Using 10.12.
[ 39%] Built target autopilot
make: *** [Makefile:160: all] Error 2

@Thra11
Copy link
Contributor Author

@Thra11 Thra11 commented Nov 1, 2020

Hmmm. Checking hydra, it looks like it's never built on darwin, so not a new issue, but according to upstream, macOs is supported, so we might as well fix it while we're here. The hydra failure on 1.4.1 is:

[  0%] Generating ../res/julius.icns
/nix/store/8i9kyqfxhk2s9dzx32x0sgdk7kyx9wjc-bash-4.4-p23/bin/bash: sips: command not found
make[2]: *** [CMakeFiles/julius.dir/build.make:82: ../res/julius.icns] Error 127
make[1]: *** [CMakeFiles/Makefile2:116: CMakeFiles/julius.dir/all] Error 2
make: *** [Makefile:160: all] Error 2
builder for '/nix/store/7wcyk8awnj2wrc5yvpn6q2zcppyaxlim-julius-1.4.1.drv' failed with exit code 2

@SuperSandro2000, do you have the full logs for the failed darwin build? Is it the same issue as before, sips: command not found? I assume we need to add whatever packages sips is part of to the nativeBuildInputs when building on darwin.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 1, 2020

Scrolled up and the lines before compiling are

/nix/store/8i9kyqfxhk2s9dzx32x0sgdk7kyx9wjc-bash-4.4-p23/bin/bash: sips: command not found                                                                                                  make[2]: *** [CMakeFiles/julius.dir/build.make:82: ../res/julius.icns] Error 127

@Thra11
Copy link
Contributor Author

@Thra11 Thra11 commented Nov 1, 2020

Thanks! Looks like sips is still the issue then.

I did find this in another package:

--replace 'sips -s format icns data/$(name).png --out out/$(name).app/Contents/Resources/$(name).icns' \
'png2icns out/$(name).app/Contents/Resources/$(name).icns data/$(name).png'
done
'';
nativeBuildInputs = [ pkgconfig ]
++ optionals stdenv.isDarwin [ libicns ];

@Thra11 Thra11 mentioned this pull request Nov 14, 2020
10 tasks
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 14, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/38

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 23, 2020

Can you mark the package broken on darwin?

Mark as broken on darwin
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 26, 2020

Result of nixpkgs-review pr 102263 run on x86_64-linux 1

1 package built:
  • julius

@SuperSandro2000 SuperSandro2000 merged commit 56e6adf into NixOS:master Nov 26, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c96656d"; rev="c96656d306a11f70aac5089b967b295801cfa588"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c96656d"; rev="c96656d306a11f70aac5089b967b295801cfa588"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c96656d"; rev="c96656d306a11f70aac5089b967b295801cfa588"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c96656d"; rev="c96656d306a11f70aac5089b967b295801cfa588"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c96656d"; rev="c96656d306a11f70aac5089b967b295801cfa588"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c96656d"; rev="c96656d306a11f70aac5089b967b295801cfa588"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c96656d"; rev="c96656d306a11f70aac5089b967b295801cfa588"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
julius, julius.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
julius, julius.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants