Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timekeeper gtk app #102265

Merged
merged 1 commit into from Nov 10, 2020
Merged

Timekeeper gtk app #102265

merged 1 commit into from Nov 10, 2020

Conversation

@bburdette
Copy link
Contributor

@bburdette bburdette commented Oct 31, 2020

Motivation for this change

Add my TimeKeeper gtk app for tracking hours.

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x] Ensured that relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
@bburdette
Copy link
Contributor Author

@bburdette bburdette commented Oct 31, 2020

had to make some minor adjustments to the suggestions - parens and the mkdir failed without the -p.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

had to make some minor adjustments to the suggestions - parens and the mkdir failed without the -p.

Can you squash the commits together? The repo has so many so we want to keep not to many and it makes backporting way easier. Also you don't need to apply everything I suggest. I just do a quick look for nitpicks.

@bburdette bburdette force-pushed the timekeeper branch 2 times, most recently from 6b8d2a5 to 3f61fbe Oct 31, 2020
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/timekeeper/default.nix Outdated Show resolved Hide resolved
poco
pkgconfig
] ++ (with gnome2; [
gtkmm
Copy link
Contributor

@jtojnar jtojnar Oct 31, 2020

Also, is it not possible to build the app against gtkmm3? GTK 2 and libglade has been deprecated for ages.

Copy link
Contributor Author

@bburdette bburdette Nov 1, 2020

I haven't worked on this code in about 10 years. I wanted to just compile it and make it available, not rewrite it. I'll see if it will work without having to work on the code. If I have to do a significant rewrite I'll probably bail on publishing.

Copy link
Contributor Author

@bburdette bburdette Nov 1, 2020

Ok I fixed all the things but not this. If its really a deal breaker I'll see what I can do.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 31, 2020

Finally, could you please follow the contribution guide for commit messages:

https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102265 run on x86_64-linux 1

1 package built:
  • timekeeper

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
kisik21
kisik21 approved these changes Nov 2, 2020
kisik21
kisik21 approved these changes Nov 2, 2020
@domenkozar domenkozar merged commit fdb4b55 into NixOS:master Nov 10, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants