Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1password: add shell completion #102268

Closed
wants to merge 3 commits into from
Closed

Conversation

@SuperPaintman
Copy link

@SuperPaintman SuperPaintman commented Oct 31, 2020

Motivation for this change

1password (op) has built-in completion for bash and zsh but they weren't installed in package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 31, 2020

Result of nixpkgs-review pr 102268 run on x86_64-linux 1

1 package built:
  • _1password

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 1, 2020

Result of nixpkgs-review pr 102268 run on x86_64-darwin 1

1 package failed to build:
  • _1password

🤔

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
24585 blocks
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
building
no Makefile, doing nothing
@nix { "action": "setPhase", "phase": "installPhase" }
installing
@nix { "action": "setPhase", "phase": "fixupPhase" }
post-installation fixup
patching script interpreter paths in /nix/store/85w4a485drlwirx5s4ai2wp5znj9sgvh-1password-1.7.0
@nix { "action": "setPhase", "phase": "installCheckPhase" }
running install tests
1.7.0
@nix { "action": "setPhase", "phase": "postInstall" }
postInstall
install: skipping file '/dev/fd/63', as it was replaced while being copied

@SuperPaintman
Copy link
Author

@SuperPaintman SuperPaintman commented Nov 1, 2020

Hah, sounds strange.

I've replaced process substitutions with regular files.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 1, 2020

Result of nixpkgs-review pr 102268 run on x86_64-darwin 1

1 package built:
  • _1password

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Can you squash the commits together?

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

Result of nixpkgs-review pr 102268 run on x86_64-darwin 1

1 package built:
  • _1password

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

Result of nixpkgs-review pr 102268 run on x86_64-linux 1

1 package built:
  • _1password

dontStrip = stdenv.isDarwin;

nativeBuildInputs = stdenv.lib.optionals stdenv.isLinux [ autoPatchelfHook ];
nativeBuildInputs = [ installShellFiles ] ++ stdenv.lib.optionals stdenv.isLinux [ autoPatchelfHook ];
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 18, 2021

Suggested change
nativeBuildInputs = [ installShellFiles ] ++ stdenv.lib.optionals stdenv.isLinux [ autoPatchelfHook ];
nativeBuildInputs = [ installShellFiles ] ++ lib.optionals stdenv.isLinux [ autoPatchelfHook ];

postPhases = [ "postInstall" ];

Copy link
Member

@SuperSandro2000 SuperSandro2000 Jan 18, 2021

Is this required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants