Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogen: make reproducible #102280

Merged
merged 1 commit into from Oct 31, 2020
Merged

autogen: make reproducible #102280

merged 1 commit into from Oct 31, 2020

Conversation

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 31, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
aszlig
aszlig approved these changes Oct 31, 2020
@ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 1, 2020

I guess that means #66552 can be closed now? @delroth

@delroth
Copy link
Contributor

@delroth delroth commented Nov 1, 2020

👍 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment