Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-app-engine-go-sdk,google-cloud-sdk,google-compute-engine: Refactor to python3 #102284

Merged
merged 3 commits into from Nov 1, 2020

Conversation

@freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Oct 31, 2020

Motivation for this change

Working on #101964, focusing here on google tools

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@freezeboy freezeboy changed the title Refactor google to python3 google-app-engine-go-sdk,google-cloud-sdk,google-compute-engine: Refactor to python3 Oct 31, 2020
@ofborg ofborg bot requested a review from lufia Oct 31, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 1, 2020

Result of nixpkgs-review pr 102284 run on x86_64-darwin 1

2 packages built:
  • google-app-engine-go-sdk
  • google-cloud-sdk (google-cloud-sdk-gce)

Copy link
Contributor

@jonringer jonringer left a comment

othewise LGTM

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@freezeboy freezeboy force-pushed the refactor-google-to-python3 branch from 4c18626 to 0083b07 Nov 1, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

https://github.com/NixOS/nixpkgs/pull/102284
3 packages built:
google-app-engine-go-sdk google-cloud-sdk google-compute-engine

@jonringer jonringer merged commit 4fe0ea4 into NixOS:master Nov 1, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
google-app-engine-go-sdk, google-app-engine-go-sdk.passthru.tests, google-cloud-sdk, google-cloud-sdk.passthru.tests, google-compute-engine, google-compute-engine.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
google-app-engine-go-sdk, google-app-engine-go-sdk.passthru.tests, google-cloud-sdk, google-cloud-sdk.passthru.tests, google-compute-engine, google-compute-engine.passthru.tests on x86_64-linux Success
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0083b07"; rev="0083b0744d9106bef1398b36bc26d7664e998bb3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0083b07"; rev="0083b0744d9106bef1398b36bc26d7664e998bb3"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0083b07"; rev="0083b0744d9106bef1398b36bc26d7664e998bb3"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0083b07"; rev="0083b0744d9106bef1398b36bc26d7664e998bb3"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0083b07"; rev="0083b0744d9106bef1398b36bc26d7664e998bb3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0083b07"; rev="0083b0744d9106bef1398b36bc26d7664e998bb3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0083b07"; rev="0083b0744d9106bef1398b36bc26d7664e998bb3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@freezeboy freezeboy deleted the refactor-google-to-python3 branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants