New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tor-browser-bundle-bin: fix (noscript) extension startup #102622
Conversation
This should fix the issue with |
f0eaaf2
to
7e619b5
Compare
(pushed a change, to also unmark as broken) |
Has this been verified to not introduce impurities in the profile dir? If not, please ensure that the profile does not capture any Nix store paths in a way that may allow them to become stale. |
The only store paths I can see captured are from |
Thank you, NoScript is back for me at least for the initial start up after EDIT: after a restart, NoScript is gone again :( |
If I comment out this line though, NoScript seems to persist across restarts:
And HTTPS Everywhere is also listed in |
By gone, you mean gone from the UI or gone from |
Unfortunately that will capture store paths, if I read the comment there correctly. |
In my second test just now of your PR, NoScript persisted after a restart and didn't disappear from the UI; in my previous test, JS was enabled in the Safest mode and NoScript was missing from the UI (I didn't check about:addons). Looks like it's the same behavior I had with the 9.x versions where addons disappeared unpredictably on restarts - sometimes they persisted, sometimes not. |
Thats sad :-( |
I think I'll try to use it for a while; anyway, this is better than the original 10.x without NoScript at all. I'm not sure the state of things in 9.x are safe to call "unbroken", who knows what other weird bugs are hidden in there if the UI of the addon disappears. |
Ok, I can now reproduce your issue. NoScript doesn't function from time to time.. |
Ok, I went down a different route now, trying to force installation of NoScript via enterprise policies. |
Thank you for investing time into this... I'm too unfamiliar with the architecture of the profile to understand what is going on. I was thinking though - is there a possibility of an altogether different way of using TBB at all, perhaps by using buildFHSUserEnv and run the unmodified TBB from torproject.org? This way it would self-manage its installation wherever we install it, per-user. What do you think? |
Actually I had the same thought. |
I just got the original TBB running in { pkgs ? import <nixpkgs> {} }:
(pkgs.buildFHSUserEnv {
name = "tbb-env";
targetPkgs = pkgs: (with pkgs;
[ udev
zlib
alsaLib
curl
gnutar
gtk3
atk
cairo
dbus
dbus-glib
fontconfig
freetype
gdk-pixbuf
glib
gtk3
xorg.libxcb
xorg.libX11
xorg.libXext
xorg.libXrender
xorg.libXt
pango
libpulseaudio
apulse
# Media support (implies audio support)
ffmpeg_3
gmp
python27
]);
runScript = "bash";
}).env |
Thanks! Here we go: #103156 |
Motivation for this change
Fix the
noscript
part of #83096Things done
Tested locally; this seems to fix the issue.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)