Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bintools-wrapper: remove redundant arg #103053

Merged
merged 2 commits into from Nov 13, 2020
Merged

bintools-wrapper: remove redundant arg #103053

merged 2 commits into from Nov 13, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 7, 2020

Motivation for this change

Fix #101330

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
zowoq added 2 commits Nov 7, 2020
cctools 949.0.1 warns if min version is passed twice.
This reverts commit d73cc1e.
@r-burns
Copy link
Contributor

@r-burns r-burns commented Nov 7, 2020

I think #101602 can now be reverted as well

@zowoq
Copy link
Contributor Author

@zowoq zowoq commented Nov 7, 2020

I think #101602 can now be reverted as well

Yeah, I'll do that after this lands in master so it doesn't interfere the workflow on the haskell-updates branch.

@r-burns
r-burns approved these changes Nov 7, 2020
Copy link
Contributor

@r-burns r-burns left a comment

Rebuilt stdenv + affected packages a couple weeks ago, worked for me #101330 (comment)

@thefloweringash thefloweringash mentioned this pull request Nov 9, 2020
3 of 14 tasks complete
@zowoq zowoq merged commit 051812b into NixOS:staging Nov 13, 2020
17 checks passed
17 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a6acf9a"; rev="a6acf9ab3175f0ec34f43f59f4685a0faa99e674"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a6acf9a"; rev="a6acf9ab3175f0ec34f43f59f4685a0faa99e674"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a6acf9a"; rev="a6acf9ab3175f0ec34f43f59f4685a0faa99e674"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a6acf9a"; rev="a6acf9ab3175f0ec34f43f59f4685a0faa99e674"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a6acf9a"; rev="a6acf9ab3175f0ec34f43f59f4685a0faa99e674"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a6acf9a"; rev="a6acf9ab3175f0ec34f43f59f4685a0faa99e674"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a6acf9a"; rev="a6acf9ab3175f0ec34f43f59f4685a0faa99e674"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@zowoq zowoq deleted the zowoq:sigh branch Nov 13, 2020
Copy link
Contributor

@marsam marsam left a comment

Sorry I'm late. LGTM, thanks!.
Reading the git history about this flag, seem to be okay to remove it:

The -macosx_version_min flag isn't strictly necessary since that's already handled by MACOSX_DEPLOYMENT_TARGET.
a826b49

the compiler always adds the flag [-macos_version_min] based on the variable [MACOSX_DEPLOYMENT_TARGET], overriding this original one, it's not really necessary. Added it just in case but should be fine to leave out if you're concerned about it. #77632 (comment)

@uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Dec 3, 2020

I think this broke bazel on darwin: #105439

@uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Dec 3, 2020

Verified reverting this fixes both bazel and libmodplug, which are currently broken on master. It's possible other packages are affected too.

@avdv
Copy link
Contributor

@avdv avdv commented Dec 4, 2020

I have created #105573 to track this down.

@bobrik bobrik mentioned this pull request Dec 26, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.