haskell: Add hoogle option to developPackage #103061
Conversation
name hoogle -> withHoogle for consistency with other makeShell |
I left a few comments. Also, it would be nice if you wrote some documentation for end users who want to use Hoogle. Could you add a sentence or two for what an end user would be able to do by enabling the It'd also be nice to have a test for |
Such a test would involve import-from-derivation, is that permissible in nixpkgs? |
Ah, good call. I guess you could always just mark it |
Right, perhaps best for another PR |
Aside from the one remaining comment, I think this looks really good. I'm going to leave this open for a few days, so that any else that got notified has a chance to comment on the change in @expipiplus1 If there are no additional comments to this in a few days, please feel free to ping me and I will merge it in (assuming the test thing has been fixed). |
Will do, thanks |
@cdepillabout ping! |
I don't think that @ofborg's failure is to do with this PR |
Thanks! |
|
Also add
composeExtensionss
to lib.This seems to be a sensible way of getting
ghcWithHoogle
into the mix.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)