Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.digestif: 0.8.0 → 0.9.0 #103082

Merged
merged 1 commit into from Nov 13, 2020
Merged

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 7, 2020

Motivation for this change

SHA3: https://github.com/mirage/digestif/releases/tag/v0.9.0

Use Dune 2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@vbgl
Copy link
Contributor Author

@vbgl vbgl commented Nov 8, 2020

@GrahamcOfBorg build ocamlPackages.irmin-unix

propagatedBuildInputs = [ bigarray-compat eqaf stdlib-shims ];

doCheck = true;
checkInputs = [ alcotest ];

This comment has been minimized.

@sternenseemann

sternenseemann Nov 13, 2020
Member

digestif.opam lists bos, astring, fpath, rresult as test dependencies and findlib as build dependency. Maybe sensible to add the explicitly instead of relying on propagation?

This comment has been minimized.

@vbgl

vbgl Nov 13, 2020
Author Contributor

Maybe the digestif.opam is out of date?

This comment has been minimized.

@sternenseemann

sternenseemann Nov 13, 2020
Member

Seems to be necessary for https://github.com/mirage/digestif/blob/f97216b8f3a501c8f0197be338ce85145fb46443/test/test_runes.ml. Seems like this test is invoked separately which we could (should?) do as well.

This comment has been minimized.

@vbgl

vbgl Nov 13, 2020
Author Contributor

Well spotted. I’ve thus added a postCheck attribute to run that lone test explicitly.

Copy link
Member

@sternenseemann sternenseemann left a comment

Aside from comments, build and build of reverse dependencies is fine (aside from irmin-{unix,http} test flakey-ness).

@vbgl vbgl force-pushed the vbgl:ocaml-digestif-0.9.0 branch from 9eb43ba to ac793a0 Nov 13, 2020
@vbgl vbgl merged commit 1ce26aa into NixOS:master Nov 13, 2020
16 checks passed
16 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ac793a0"; rev="ac793a05f997eb4de7376c4bf1ec248de133ae8b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ac793a0"; rev="ac793a05f997eb4de7376c4bf1ec248de133ae8b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ac793a0"; rev="ac793a05f997eb4de7376c4bf1ec248de133ae8b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ac793a0"; rev="ac793a05f997eb4de7376c4bf1ec248de133ae8b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ac793a0"; rev="ac793a05f997eb4de7376c4bf1ec248de133ae8b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ac793a0"; rev="ac793a05f997eb4de7376c4bf1ec248de133ae8b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ac793a0"; rev="ac793a05f997eb4de7376c4bf1ec248de133ae8b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@vbgl vbgl deleted the vbgl:ocaml-digestif-0.9.0 branch Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants