Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave: 1.15.76 -> 1.16.72 #103268

Merged
merged 1 commit into from Nov 13, 2020
Merged

Conversation

@JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Nov 10, 2020

Motivation for this change

The browser needs to be up to be up-to-date at all time

Things done

Update version from 1.15.76 to 1.16.72

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dbirks
dbirks approved these changes Nov 11, 2020
Copy link
Member

@dbirks dbirks left a comment

Builds and runs nicely for me on NixOS. 👍

Just one nit that the commit message says 1.5.76 instead of 1.15.76. 🔍

@JeffLabonte JeffLabonte force-pushed the JeffLabonte:update/brave_1.15.76_to_1.16.72 branch from a1e3eea to 13e4f18 Nov 11, 2020
@samueldr samueldr merged commit 5f936da into NixOS:master Nov 13, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
brave, brave.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
brave, brave.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="13e4f18"; rev="13e4f189a1db7d1d9090d5da60d0eec09f18fdbf"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="13e4f18"; rev="13e4f189a1db7d1d9090d5da60d0eec09f18fdbf"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="13e4f18"; rev="13e4f189a1db7d1d9090d5da60d0eec09f18fdbf"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="13e4f18"; rev="13e4f189a1db7d1d9090d5da60d0eec09f18fdbf"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="13e4f18"; rev="13e4f189a1db7d1d9090d5da60d0eec09f18fdbf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="13e4f18"; rev="13e4f189a1db7d1d9090d5da60d0eec09f18fdbf"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="13e4f18"; rev="13e4f189a1db7d1d9090d5da60d0eec09f18fdbf"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@JeffLabonte JeffLabonte mentioned this pull request Nov 13, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.