Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Package.mautrix: 0.5.8 -> 0.8.1 #103319

Closed
wants to merge 1 commit into from

Conversation

@Scriptkiddi
Copy link
Contributor

@Scriptkiddi Scriptkiddi commented Nov 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 10, 2020

Why would you need this? The only package which actually uses this (mautrix-telegram) still requires <0.6 of this library on its latest stable release (0.8.2).

@Ma27 Ma27 closed this Nov 10, 2020
@Scriptkiddi Scriptkiddi reopened this Nov 10, 2020
@Scriptkiddi
Copy link
Contributor Author

@Scriptkiddi Scriptkiddi commented Nov 10, 2020

Its a matrix framework, im using it to write small bots for our matrix server

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 10, 2020

May I ask what prevents you from using an overlay for now?

@Scriptkiddi
Copy link
Contributor Author

@Scriptkiddi Scriptkiddi commented Nov 12, 2020

May I ask what prevents you from using an overlay for now?

Im using an overlay but I figured we should keep packages up to date

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 12, 2020

but I figured we should keep packages up to date

That's understandable, but IMHO it's even more important to keep our package-set stable than having every single package up-to-date. And in this case, the change would break existing stuff.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

I did a PR (#105336) which resolved the broken package and updates mautrix.

@Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 29, 2020

I did a PR (#105336) which resolved the broken package and updates mautrix.

There was no broken package as it wasn't merged or am I misunderstanding you?

@Scriptkiddi Scriptkiddi deleted the mautrix branch Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants