Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] backport of graalvm{8,11}-ce, babashka clj kondo #103598

Merged

Conversation

@bennyandresen
Copy link
Contributor

@bennyandresen bennyandresen commented Nov 12, 2020

Motivation for this change

clj-kondo and babashka is currently broken on 20.09 and this fixed it

cherry-picked from, PR and message
674c9af #99631 graalvm{8,11}-ce: init at 20.2.0
3341f6c #102693 babashka,clj-kondo: Depend on graalvm-ce
172cbb8 #102867 babashka: 0.0.97 -> 0.2.3
045c2ab #103096 clj-kondo: 2020.04.05 -> 2020.11.07

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

cc: @jonringer @glittershark

bennyandresen and others added 4 commits Jul 14, 2020
(cherry picked from commit 674c9af)
Now that we have community builds of graalvm landed in #99631, both
clj-kondo and babashka can depend on those versions of graalvm rather
than the one that requires building from source - this can be built in
hydra, and generally is much easier to build and test.

(cherry picked from commit 3341f6c)
with #99631 and #102693 merged, it's possible to bump the babashka
version again.

However recent versions of babashka depend on java11 features and I
spoke in Slack with the project lead and this java11 dependency will
exist going forward.

(cherry picked from commit 172cbb8)
(cherry picked from commit 045c2ab)
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 12, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@bennyandresen bennyandresen changed the title Backport gralvm babashka clj kondo [20.09] backport of graalvm{8,11}-ce, babashka clj kondo Nov 12, 2020
@ofborg ofborg bot requested review from hlolli and jlesquembre Nov 12, 2020
@ofborg ofborg bot requested a review from volth Nov 12, 2020
@bennyandresen
Copy link
Contributor Author

@bennyandresen bennyandresen commented Nov 13, 2020

/status needs_merger

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 13, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/283

@glittershark
Copy link
Member

@glittershark glittershark commented Nov 13, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot added needs_merger and removed awaiting_reviewer labels Nov 13, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau Nov 13, 2020
@marvin-mk2 marvin-mk2 bot added awaiting_merger and removed needs_merger labels Nov 13, 2020
Copy link
Member

@timokau timokau left a comment

Thank you, and thanks @glittershark for the initial review.

@timokau timokau merged commit 4b81fc8 into NixOS:release-20.09 Nov 13, 2020
18 checks passed
18 checks passed
action
Details
babashka, babashka.passthru.tests, clj-kondo, clj-kondo.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
babashka, babashka.passthru.tests, clj-kondo, clj-kondo.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e8a00d"; rev="6e8a00d4fd5017550d0832a47a8890b7b2420664"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e8a00d"; rev="6e8a00d4fd5017550d0832a47a8890b7b2420664"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e8a00d"; rev="6e8a00d4fd5017550d0832a47a8890b7b2420664"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e8a00d"; rev="6e8a00d4fd5017550d0832a47a8890b7b2420664"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e8a00d"; rev="6e8a00d4fd5017550d0832a47a8890b7b2420664"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e8a00d"; rev="6e8a00d4fd5017550d0832a47a8890b7b2420664"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6e8a00d"; rev="6e8a00d4fd5017550d0832a47a8890b7b2420664"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants