Fix a dependency issue where a runtime dependency was added only as a build dependency.
fusermount3 is required at runtime for the package. Some non-NixOS systems such as Ubuntu 18.04 LTS have fuse2 and not fuse3, so you have to add fuse3 as a runtime dependency.
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
NixOS
macOS
other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Both buildInputs and propagateBuildInputs seem to be necessary. Without buildInputs, it fails to build:
checking for fuse3 >= 3.2.1... no
configure: error: *** libfuse not found
builder for '/nix/store/jbsn5kasbdj96kk8njcmbhpdh53bc1p2-fuse-overlayfs-1.2.0.drv' failed with exit code 1
error: build of '/nix/store/jbsn5kasbdj96kk8njcmbhpdh53bc1p2-fuse-overlayfs-1.2.0.drv' failed
Sorry, I think this was wrong, so I'll close this issue.
Have you checked that this patch works on non-NixOS?
It would be necessary to wrap the program to add fuse to PATH, but no other FUSE packages do that. Installing fuse using nix-env -i on Ubuntu 18.04 LTS worked.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
Motivation for this change
Fix a dependency issue where a runtime dependency was added only as a build dependency.
fusermount3
is required at runtime for the package. Some non-NixOS systems such as Ubuntu 18.04 LTS have fuse2 and not fuse3, so you have to add fuse3 as a runtime dependency.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)