Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse-overlayfs: Propagate fuse3 #103608

Closed
wants to merge 1 commit into from
Closed

Conversation

@akirak
Copy link
Contributor

@akirak akirak commented Nov 12, 2020

Motivation for this change

Fix a dependency issue where a runtime dependency was added only as a build dependency.

fusermount3 is required at runtime for the package. Some non-NixOS systems such as Ubuntu 18.04 LTS have fuse2 and not fuse3, so you have to add fuse3 as a runtime dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@saschagrunert saschagrunert left a comment

LGTM

@akirak akirak force-pushed the akirak:fuse-overlayfs-prop-fuse branch from 6db360c to a42054f Nov 13, 2020
@akirak
Copy link
Contributor Author

@akirak akirak commented Nov 13, 2020

Both buildInputs and propagateBuildInputs seem to be necessary. Without buildInputs, it fails to build:

checking for fuse3 >= 3.2.1... no
configure: error: *** libfuse not found
builder for '/nix/store/jbsn5kasbdj96kk8njcmbhpdh53bc1p2-fuse-overlayfs-1.2.0.drv' failed with exit code 1
error: build of '/nix/store/jbsn5kasbdj96kk8njcmbhpdh53bc1p2-fuse-overlayfs-1.2.0.drv' failed

I've changed the commit.

@ofborg ofborg bot requested a review from saschagrunert Nov 13, 2020
@zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 13, 2020

Some non-NixOS systems such as Ubuntu 18.04 LTS have fuse2 and not fuse3, so you have to add fuse3 as a runtime dependency.

Have you checked that this patch works on non-NixOS?

@akirak
Copy link
Contributor Author

@akirak akirak commented Nov 13, 2020

Sorry, I think this was wrong, so I'll close this issue.

Have you checked that this patch works on non-NixOS?

It would be necessary to wrap the program to add fuse to PATH, but no other FUSE packages do that. Installing fuse using nix-env -i on Ubuntu 18.04 LTS worked.

@akirak akirak closed this Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.