Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdsh: enable optional slurm support #103652

Merged
merged 1 commit into from Nov 24, 2020
Merged

pdsh: enable optional slurm support #103652

merged 1 commit into from Nov 24, 2020

Conversation

@dylex
Copy link
Contributor

@dylex dylex commented Nov 13, 2020

Motivation for this change

pdsh provides a number of optional modules with additional functionality. One such is the slurm module. This adds a slurmSupport option (default false) to enable it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

Result of nixpkgs-review pr 103652 run on x86_64-linux 1

1 package built:
  • pdsh
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 24, 2020

Result of nixpkgs-review pr 103652 run on x86_64-darwin 1

1 package built:
  • pdsh
@SuperSandro2000 SuperSandro2000 merged commit 715cd22 into NixOS:master Nov 24, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b3eb813"; rev="b3eb8130fe1bc29211879b2658fb69b35416bb24"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b3eb813"; rev="b3eb8130fe1bc29211879b2658fb69b35416bb24"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b3eb813"; rev="b3eb8130fe1bc29211879b2658fb69b35416bb24"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b3eb813"; rev="b3eb8130fe1bc29211879b2658fb69b35416bb24"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b3eb813"; rev="b3eb8130fe1bc29211879b2658fb69b35416bb24"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b3eb813"; rev="b3eb8130fe1bc29211879b2658fb69b35416bb24"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b3eb813"; rev="b3eb8130fe1bc29211879b2658fb69b35416bb24"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pdsh, pdsh.passthru.tests on aarch64-linux Success
Details
pdsh, pdsh.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants