Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: 4.0.1 -> 4.0.2 #103655

Merged
merged 1 commit into from Nov 16, 2020
Merged

nix-prefetch-github: 4.0.1 -> 4.0.2 #103655

merged 1 commit into from Nov 16, 2020

Conversation

@sveitser
Copy link
Contributor

@sveitser sveitser commented Nov 13, 2020 •
edited

Motivation for this change

Package Update. New version no longer uses pytest-black.

seppeljordan/nix-prefetch-github@3e1f3f9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sveitser
nix-prefetch-github: 4.0.1 -> 4.0.2
Verified
This commit was signed with a verified signature.
sveitser Mathis
GPG key ID: 765E892DAE70682C Learn about signing commits
Loading status checks…
91b3ce2
@sveitser sveitser requested review from FRidh and jonringer as code owners Nov 13, 2020
@sveitser sveitser mentioned this pull request Nov 13, 2020
Closed
@sveitser
Copy link
Contributor Author

@sveitser sveitser commented Nov 13, 2020

Result of nixpkgs-review pr 103655 1

3 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github
1 similar comment
@seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Nov 13, 2020

Result of nixpkgs-review pr 103655 1

3 packages built:
  • nix-prefetch-github (python38Packages.nix-prefetch-github)
  • pypi2nix
  • python37Packages.nix-prefetch-github
@seppeljordan
seppeljordan approved these changes Nov 13, 2020
View changes
Copy link
Contributor

@seppeljordan seppeljordan left a comment

Looks good to me. I built the package via nix-prefetch-github and tested the executable which worked without issues.
@Ma27 Ma27 merged commit 307d471 into NixOS:master Nov 16, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91b3ce2"; rev="91b3ce2953e006ea7aa9f906f6b1aaf658503365"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91b3ce2"; rev="91b3ce2953e006ea7aa9f906f6b1aaf658503365"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91b3ce2"; rev="91b3ce2953e006ea7aa9f906f6b1aaf658503365"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91b3ce2"; rev="91b3ce2953e006ea7aa9f906f6b1aaf658503365"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91b3ce2"; rev="91b3ce2953e006ea7aa9f906f6b1aaf658503365"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91b3ce2"; rev="91b3ce2953e006ea7aa9f906f6b1aaf658503365"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91b3ce2"; rev="91b3ce2953e006ea7aa9f906f6b1aaf658503365"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-prefetch-github, nix-prefetch-github.passthru.tests on aarch64-linux Success
Details
nix-prefetch-github, nix-prefetch-github.passthru.tests on x86_64-linux Success
Details
@sveitser sveitser deleted the sveitser:update-nix-prefetch-github-4.0.2 branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seppeljordan seppeljordan

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 6.topic: python
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sveitser @seppeljordan @Ma27
You can’t perform that action at this time.